From 080e04e863cbbd6d6ec0aa4b00c92ffb095a7ce3 Mon Sep 17 00:00:00 2001 From: usa Date: Mon, 26 Aug 2019 16:17:49 +0000 Subject: [PATCH] merge revision(s) 8f51da5d41f0642d5a971e4223d1ba14643c6398: [Backport #15946] Get rid of undefined behavior * string.c (rb_str_sub_bang): str and repl can be same. [Bug #15946] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67770 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- string.c | 2 +- version.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/string.c b/string.c index 5f8bd363fc..ab04ac7596 100644 --- a/string.c +++ b/string.c @@ -5016,7 +5016,7 @@ rb_str_sub_bang(int argc, VALUE *argv, VALUE str) if (rlen != plen) { memmove(p + beg0 + rlen, p + beg0 + plen, len - beg0 - plen); } - memcpy(p + beg0, rp, rlen); + memmove(p + beg0, rp, rlen); len += rlen - plen; STR_SET_LEN(str, len); TERM_FILL(&RSTRING_PTR(str)[len], TERM_LEN(str)); diff --git a/version.h b/version.h index 62221f0ddf..e08522e1c5 100644 --- a/version.h +++ b/version.h @@ -1,6 +1,6 @@ #define RUBY_VERSION "2.5.6" #define RUBY_RELEASE_DATE "2019-08-27" -#define RUBY_PATCHLEVEL 188 +#define RUBY_PATCHLEVEL 189 #define RUBY_RELEASE_YEAR 2019 #define RUBY_RELEASE_MONTH 8