archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-09-15 08:33:58 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Check that String#scrub block does not modify receiver

Browse source 
Similar to the check used for String#gsub.  Can fix possible
segfault.

Fixes [Bug #15941]
This commit is contained in:
Jeremy Evans 2019-06-19 10:44:54 -07:00
parent 7582287eb2
commit 0f283054e7
2 changed files with 25 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
test/ruby/test_m17n.rb
View file

@ -1604,6 +1604,19 @@ class TestM17N < Test::Unit::TestCase
assert_predicate(str.dup.taint.scrub, :tainted?)
end
def test_scrub_modification_inside_block
str = ("abc\u3042".b << "\xE3\x80".b).force_encoding('UTF-8')
assert_raise(RuntimeError) {str.scrub{|_| str << "1234567890"; "?" }}
str = "\x00\xD8\x42\x30".force_encoding(Encoding::UTF_16LE)
assert_raise(RuntimeError) do
str.scrub do |_|
str << "1\x002\x00".force_encoding('UTF-16LE')
"?\x00".force_encoding('UTF-16LE')
end
end
end
def test_scrub_replace_default
assert_equal("\uFFFD\uFFFD\uFFFD", u("\x80\x80\x80").scrub)
assert_equal("\uFFFDA", u("\xF4\x80\x80A").scrub)