archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-15 13:39:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

ZJIT: Don't make unnecessary Cow

Browse source
This commit is contained in:
Max Bernstein 2025-07-30 12:29:59 -04:00 • committed by Max Bernstein
parent 8c73b103cd
commit 1b700c56d8
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
zjit/src/hir.rs
View file

@ -734,18 +734,18 @@ impl<'a> std::fmt::Display for InsnPrinter<'a> {
Insn::Defined { op_type, v, .. } => {
// op_type (enum defined_type) printing logic from iseq.c.
// Not sure why rb_iseq_defined_string() isn't exhaustive.
use std::borrow::Cow;
write!(f, "Defined ")?;
let op_type = *op_type as u32;
let op_type = if op_type == DEFINED_FUNC {
Cow::Borrowed("func")
if op_type == DEFINED_FUNC {
write!(f, "func")?;
} else if op_type == DEFINED_REF {
Cow::Borrowed("ref")
write!(f, "ref")?;
} else if op_type == DEFINED_CONST_FROM {
Cow::Borrowed("constant-from")
write!(f, "constant-from")?;
} else {
String::from_utf8_lossy(unsafe { rb_iseq_defined_string(op_type).as_rstring_byte_slice().unwrap() })
write!(f, "{}", String::from_utf8_lossy(unsafe { rb_iseq_defined_string(op_type).as_rstring_byte_slice().unwrap() }))?;
};
write!(f, "Defined {op_type}, {v}")
write!(f, ", {v}")
}
Insn::DefinedIvar { self_val, id, .. } => write!(f, "DefinedIvar {self_val}, :{}", id.contents_lossy().into_owned()),
Insn::GetIvar { self_val, id, .. } => write!(f, "GetIvar {self_val}, :{}", id.contents_lossy().into_owned()),