archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-15 13:39:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

avoid (size_t)--

Browse source 
The decrements overflow and these variables remain ~0 when leaving the
while loops.  They are not fatal by accident, but better replace with
ordinal for loops.

See also: 452218871 (L3246)


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65624 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
shyouhei 2018-11-08 05:06:52 +00:00
parent f4a2170ec2
commit 24fff75045
2 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
util.c
View file

@ -35,8 +35,12 @@ ruby_scan_oct(const char *start, size_t len, size_t *retlen)
{
register const char *s = start;
register unsigned long retval = 0;
size_t i;
while (len-- && *s >= '0' && *s <= '7') {
for (i = 0; i < len; i++) {
if ((s[0] < '0') || ('7' <= s[0])) {
break;
}
retval <<= 3;
retval |= *s++ - '0';
}