merge revision(s) 38993: [Backport #7775]

* ext/socket/basicsocket.c (bsock_getsockname): ignore truncated
	  part of socket address.
	  (bsock_getpeername): ditto.
	  (bsock_local_address): ditto.
	  (bsock_remote_address): ditto.

	* ext/socket/unixsocket.c (unix_path): ditto.
	  (unix_addr): ditto.
	  (unix_peeraddr): ditto.

	* ext/socket/init.c (cloexec_accept): ditto.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@39094 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
usa 2013-02-06 05:21:33 +00:00
parent 0297247f97
commit 2618ffc57a
5 changed files with 35 additions and 2 deletions

View file

@ -1,3 +1,17 @@
Wed Feb 6 14:20:12 2013 Tanaka Akira <akr@fsij.org>
* ext/socket/basicsocket.c (bsock_getsockname): ignore truncated
part of socket address.
(bsock_getpeername): ditto.
(bsock_local_address): ditto.
(bsock_remote_address): ditto.
* ext/socket/unixsocket.c (unix_path): ditto.
(unix_addr): ditto.
(unix_peeraddr): ditto.
* ext/socket/init.c (cloexec_accept): ditto.
Wed Feb 6 14:19:07 2013 Kouhei Sutou <kou@cozmixng.org> Wed Feb 6 14:19:07 2013 Kouhei Sutou <kou@cozmixng.org>
* lib/rexml/parsers/baseparser.rb, test/rexml/test_comment.rb: * lib/rexml/parsers/baseparser.rb, test/rexml/test_comment.rb:

View file

@ -358,11 +358,13 @@ bsock_getsockname(VALUE sock)
{ {
struct sockaddr_storage buf; struct sockaddr_storage buf;
socklen_t len = (socklen_t)sizeof buf; socklen_t len = (socklen_t)sizeof buf;
socklen_t len0 = len;
rb_io_t *fptr; rb_io_t *fptr;
GetOpenFile(sock, fptr); GetOpenFile(sock, fptr);
if (getsockname(fptr->fd, (struct sockaddr*)&buf, &len) < 0) if (getsockname(fptr->fd, (struct sockaddr*)&buf, &len) < 0)
rb_sys_fail("getsockname(2)"); rb_sys_fail("getsockname(2)");
if (len0 < len) len = len0;
return rb_str_new((char*)&buf, len); return rb_str_new((char*)&buf, len);
} }
@ -387,11 +389,13 @@ bsock_getpeername(VALUE sock)
{ {
struct sockaddr_storage buf; struct sockaddr_storage buf;
socklen_t len = (socklen_t)sizeof buf; socklen_t len = (socklen_t)sizeof buf;
socklen_t len0 = len;
rb_io_t *fptr; rb_io_t *fptr;
GetOpenFile(sock, fptr); GetOpenFile(sock, fptr);
if (getpeername(fptr->fd, (struct sockaddr*)&buf, &len) < 0) if (getpeername(fptr->fd, (struct sockaddr*)&buf, &len) < 0)
rb_sys_fail("getpeername(2)"); rb_sys_fail("getpeername(2)");
if (len0 < len) len = len0;
return rb_str_new((char*)&buf, len); return rb_str_new((char*)&buf, len);
} }
@ -475,11 +479,13 @@ bsock_local_address(VALUE sock)
{ {
struct sockaddr_storage buf; struct sockaddr_storage buf;
socklen_t len = (socklen_t)sizeof buf; socklen_t len = (socklen_t)sizeof buf;
socklen_t len0 = len;
rb_io_t *fptr; rb_io_t *fptr;
GetOpenFile(sock, fptr); GetOpenFile(sock, fptr);
if (getsockname(fptr->fd, (struct sockaddr*)&buf, &len) < 0) if (getsockname(fptr->fd, (struct sockaddr*)&buf, &len) < 0)
rb_sys_fail("getsockname(2)"); rb_sys_fail("getsockname(2)");
if (len0 < len) len = len0;
return rsock_fd_socket_addrinfo(fptr->fd, (struct sockaddr *)&buf, len); return rsock_fd_socket_addrinfo(fptr->fd, (struct sockaddr *)&buf, len);
} }
@ -507,11 +513,13 @@ bsock_remote_address(VALUE sock)
{ {
struct sockaddr_storage buf; struct sockaddr_storage buf;
socklen_t len = (socklen_t)sizeof buf; socklen_t len = (socklen_t)sizeof buf;
socklen_t len0 = len;
rb_io_t *fptr; rb_io_t *fptr;
GetOpenFile(sock, fptr); GetOpenFile(sock, fptr);
if (getpeername(fptr->fd, (struct sockaddr*)&buf, &len) < 0) if (getpeername(fptr->fd, (struct sockaddr*)&buf, &len) < 0)
rb_sys_fail("getpeername(2)"); rb_sys_fail("getpeername(2)");
if (len0 < len) len = len0;
return rsock_fd_socket_addrinfo(fptr->fd, (struct sockaddr *)&buf, len); return rsock_fd_socket_addrinfo(fptr->fd, (struct sockaddr *)&buf, len);
} }

View file

@ -448,6 +448,7 @@ VALUE
rsock_s_accept_nonblock(VALUE klass, rb_io_t *fptr, struct sockaddr *sockaddr, socklen_t *len) rsock_s_accept_nonblock(VALUE klass, rb_io_t *fptr, struct sockaddr *sockaddr, socklen_t *len)
{ {
int fd2; int fd2;
socklen_t len0 = len ? *len : 0;
rb_secure(3); rb_secure(3);
rb_io_set_nonblock(fptr); rb_io_set_nonblock(fptr);
@ -466,6 +467,7 @@ rsock_s_accept_nonblock(VALUE klass, rb_io_t *fptr, struct sockaddr *sockaddr, s
} }
rb_sys_fail("accept(2)"); rb_sys_fail("accept(2)");
} }
if (len && len0 < *len) *len = len0;
rb_update_max_fd(fd2); rb_update_max_fd(fd2);
make_fd_nonblock(fd2); make_fd_nonblock(fd2);
return rsock_init_sock(rb_obj_alloc(klass), fd2); return rsock_init_sock(rb_obj_alloc(klass), fd2);
@ -481,7 +483,12 @@ static VALUE
accept_blocking(void *data) accept_blocking(void *data)
{ {
struct accept_arg *arg = data; struct accept_arg *arg = data;
return (VALUE)accept(arg->fd, arg->sockaddr, arg->len); int ret;
socklen_t len0 = 0;
if (arg->len) len0 = *arg->len;
ret = accept(arg->fd, arg->sockaddr, arg->len);
if (arg->len && len0 < *arg->len) *arg->len = len0;
return (VALUE)ret;
} }
VALUE VALUE

View file

@ -116,8 +116,10 @@ unix_path(VALUE sock)
if (NIL_P(fptr->pathv)) { if (NIL_P(fptr->pathv)) {
struct sockaddr_un addr; struct sockaddr_un addr;
socklen_t len = (socklen_t)sizeof(addr); socklen_t len = (socklen_t)sizeof(addr);
socklen_t len0 = len;
if (getsockname(fptr->fd, (struct sockaddr*)&addr, &len) < 0) if (getsockname(fptr->fd, (struct sockaddr*)&addr, &len) < 0)
rb_sys_fail(0); rb_sys_fail(0);
if (len0 < len) len = len0;
fptr->pathv = rb_obj_freeze(rb_str_new_cstr(rsock_unixpath(&addr, len))); fptr->pathv = rb_obj_freeze(rb_str_new_cstr(rsock_unixpath(&addr, len)));
} }
return rb_str_dup(fptr->pathv); return rb_str_dup(fptr->pathv);
@ -445,11 +447,13 @@ unix_peeraddr(VALUE sock)
rb_io_t *fptr; rb_io_t *fptr;
struct sockaddr_un addr; struct sockaddr_un addr;
socklen_t len = (socklen_t)sizeof addr; socklen_t len = (socklen_t)sizeof addr;
socklen_t len0 = len;
GetOpenFile(sock, fptr); GetOpenFile(sock, fptr);
if (getpeername(fptr->fd, (struct sockaddr*)&addr, &len) < 0) if (getpeername(fptr->fd, (struct sockaddr*)&addr, &len) < 0)
rb_sys_fail("getpeername(2)"); rb_sys_fail("getpeername(2)");
if (len0 < len) len = len0;
return rsock_unixaddr(&addr, len); return rsock_unixaddr(&addr, len);
} }

View file

@ -1,5 +1,5 @@
#define RUBY_VERSION "1.9.3" #define RUBY_VERSION "1.9.3"
#define RUBY_PATCHLEVEL 379 #define RUBY_PATCHLEVEL 380
#define RUBY_RELEASE_DATE "2013-02-06" #define RUBY_RELEASE_DATE "2013-02-06"
#define RUBY_RELEASE_YEAR 2013 #define RUBY_RELEASE_YEAR 2013