merge revision(s) 55581,55582: [Backport #12557]

* lib/net/http/generic_rquest.rb (write_header): A Request-Line must
	  not contain CR or LF.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@55874 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
usa 2016-08-12 02:46:40 +00:00
parent 9bfab3c125
commit 26df8ea5bb
4 changed files with 23 additions and 2 deletions

View file

@ -1,3 +1,8 @@
Fri Aug 12 11:45:02 2016 Shugo Maeda <shugo@ruby-lang.org>
* lib/net/http/generic_rquest.rb (write_header): A Request-Line must
not contain CR or LF.
Fri Aug 12 11:41:41 2016 Shugo Maeda <shugo@ruby-lang.org> Fri Aug 12 11:41:41 2016 Shugo Maeda <shugo@ruby-lang.org>
* lib/net/ftp.rb (putline): raise an ArgumentError when * lib/net/ftp.rb (putline): raise an ArgumentError when

View file

@ -320,7 +320,12 @@ class Net::HTTPGenericRequest
end end
def write_header(sock, ver, path) def write_header(sock, ver, path)
buf = "#{@method} #{path} HTTP/#{ver}\r\n" reqline = "#{@method} #{path} HTTP/#{ver}"
if /[\r\n]/ =~ reqline
raise ArgumentError, "A Request-Line must not contain CR or LF"
end
buf = ""
buf << reqline << "\r\n"
each_capitalized do |k,v| each_capitalized do |k,v|
buf << "#{k}: #{v}\r\n" buf << "#{k}: #{v}\r\n"
end end

View file

@ -291,6 +291,17 @@ module TestNetHTTP_version_1_1_methods
assert_equal $test_net_http_data, res.body assert_equal $test_net_http_data, res.body
end end
def test_get__crlf
start {|http|
assert_raise(ArgumentError) do
http.get("\r")
end
assert_raise(ArgumentError) do
http.get("\n")
end
}
end
def test_get2 def test_get2
start {|http| start {|http|
http.get2('/') {|res| http.get2('/') {|res|

View file

@ -1,6 +1,6 @@
#define RUBY_VERSION "2.2.6" #define RUBY_VERSION "2.2.6"
#define RUBY_RELEASE_DATE "2016-08-12" #define RUBY_RELEASE_DATE "2016-08-12"
#define RUBY_PATCHLEVEL 346 #define RUBY_PATCHLEVEL 347
#define RUBY_RELEASE_YEAR 2016 #define RUBY_RELEASE_YEAR 2016
#define RUBY_RELEASE_MONTH 8 #define RUBY_RELEASE_MONTH 8