archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-28 15:36:16 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

[ruby/prism] Implement multi target nodes for ripper translation

Browse source 
ceb5a5cf62
This commit is contained in:
Kevin Newton 2024-03-05 08:42:13 -05:00 • committed by git
parent fabece2507
commit 2cb75b8f17
2 changed files with 21 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

24
lib/prism/translation/ripper.rb
View file

@ -1571,10 +1571,28 @@ module Prism
on_module(constant_path, bodystmt) on_module(constant_path, bodystmt)
end end
# foo, bar = baz # (foo, bar), bar = qux
# ^^^^^^^^ # ^^^^^^^^^^
def visit_multi_target_node(node) def visit_multi_target_node(node)
raise NoMethodError, __method__ bounds(node.location)
targets =
[*node.lefts, *node.rest, *node.rights].inject(on_mlhs_new) do |mlhs, target|
bounds(target.location)
if target.is_a?(ImplicitRestNode)
on_excessed_comma # these do not get put into the targets
mlhs
else
on_mlhs_add(mlhs, visit(target))
end
end
if node.lparen_loc.nil?
targets
else
bounds(node.lparen_loc)
on_mlhs_paren(targets)
end
end end
# foo, bar = baz # foo, bar = baz

10
test/prism/ripper_test.rb
View file

@ -290,7 +290,6 @@ module Prism
embdoc_no_newline_at_end.txt embdoc_no_newline_at_end.txt
emoji_method_calls.txt emoji_method_calls.txt
endless_methods.txt endless_methods.txt
for.txt
global_variables.txt global_variables.txt
hashes.txt hashes.txt
heredoc_with_escaped_newline_at_start.txt heredoc_with_escaped_newline_at_start.txt
@ -342,15 +341,10 @@ module Prism
seattlerb/bug191.txt seattlerb/bug191.txt
seattlerb/bug_215.txt seattlerb/bug_215.txt
seattlerb/bug_249.txt seattlerb/bug_249.txt
seattlerb/bug_args__19.txt
seattlerb/bug_args_masgn.txt
seattlerb/bug_args_masgn2.txt
seattlerb/bug_args_masgn_outer_parens__19.txt
seattlerb/bug_call_arglist_parens.txt seattlerb/bug_call_arglist_parens.txt
seattlerb/bug_comma.txt seattlerb/bug_comma.txt
seattlerb/bug_hash_args_trailing_comma.txt seattlerb/bug_hash_args_trailing_comma.txt
seattlerb/bug_hash_interp_array.txt seattlerb/bug_hash_interp_array.txt
seattlerb/bug_masgn_right.txt
seattlerb/bug_not_parens.txt seattlerb/bug_not_parens.txt
seattlerb/call_args_assoc_quoted.txt seattlerb/call_args_assoc_quoted.txt
seattlerb/call_args_assoc_trailing_comma.txt seattlerb/call_args_assoc_trailing_comma.txt
@ -431,8 +425,6 @@ module Prism
seattlerb/index_0_opasgn.txt seattlerb/index_0_opasgn.txt
seattlerb/interpolated_symbol_array_line_breaks.txt seattlerb/interpolated_symbol_array_line_breaks.txt
seattlerb/interpolated_word_array_line_breaks.txt seattlerb/interpolated_word_array_line_breaks.txt
seattlerb/iter_args_2__19.txt
seattlerb/iter_args_3.txt
seattlerb/lambda_do_vs_brace.txt seattlerb/lambda_do_vs_brace.txt
seattlerb/lasgn_command.txt seattlerb/lasgn_command.txt
seattlerb/lasgn_middle_splat.txt seattlerb/lasgn_middle_splat.txt
@ -641,7 +633,6 @@ module Prism
whitequark/endless_method_forwarded_args_legacy.txt whitequark/endless_method_forwarded_args_legacy.txt
whitequark/endless_method_with_rescue_mod.txt whitequark/endless_method_with_rescue_mod.txt
whitequark/endless_method_without_args.txt whitequark/endless_method_without_args.txt
whitequark/for_mlhs.txt
whitequark/forward_arg.txt whitequark/forward_arg.txt
whitequark/forward_arg_with_open_args.txt whitequark/forward_arg_with_open_args.txt
whitequark/forward_args_legacy.txt whitequark/forward_args_legacy.txt
@ -686,7 +677,6 @@ module Prism
whitequark/pattern_matching_blank_else.txt whitequark/pattern_matching_blank_else.txt
whitequark/pattern_matching_else.txt whitequark/pattern_matching_else.txt
whitequark/pattern_matching_single_line_allowed_omission_of_parentheses.txt whitequark/pattern_matching_single_line_allowed_omission_of_parentheses.txt
whitequark/procarg0.txt
whitequark/resbody_var.txt whitequark/resbody_var.txt
whitequark/rescue_else.txt whitequark/rescue_else.txt
whitequark/rescue_else_ensure.txt whitequark/rescue_else_ensure.txt