archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-15 13:39:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[ruby/prism] Only read from buffer if size is greater than 0

Browse source 
It looks like we can possibly do an out of bounds read if size is equal
to 0.  This commit adds a conditional to ensure size is actually greater
than 0 before looking backwards in the buffer

2031b626e6
This commit is contained in:
Aaron Patterson 2024-10-28 13:21:14 -07:00 • committed by git
parent 83568a41af
commit 3c9be02af1
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
prism/util/pm_char.c
View file

@ -185,7 +185,7 @@ pm_strspn_number_kind_underscores(const uint8_t *string, ptrdiff_t length, const
size++;
}
if (string[size - 1] == '_') *invalid = string + size - 1;
if (size > 0 && string[size - 1] == '_') *invalid = string + size - 1;
return size;
}