merge revision(s) 59693,59695: [Backport #13852]

A HTTP Header value must not contain CR or LF.
	to_str -> to_s

	* lib/net/http/header.rb (set_field): `val` can not have `to_str`.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@59783 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
nagachika 2017-09-08 14:27:38 +00:00
parent 05bc6eb40a
commit 48d7802858
3 changed files with 42 additions and 3 deletions

View file

@ -42,7 +42,7 @@ module Net::HTTPHeader
@header.delete key.downcase
return val
end
@header[key.downcase] = [val]
set_field(key, val)
end
# [Ruby 1.8.3]
@ -62,12 +62,40 @@ module Net::HTTPHeader
#
def add_field(key, val)
if @header.key?(key.downcase)
@header[key.downcase].push val
append_field_value(@header[key.downcase], val)
else
set_field(key, val)
end
end
private def set_field(key, val)
case val
when Enumerable
ary = []
append_field_value(ary, val)
@header[key.downcase] = ary
else
val = val.to_s
if /[\r\n]/.match?(val)
raise ArgumentError, 'header field value cannnot include CR/LF'
end
@header[key.downcase] = [val]
end
end
private def append_field_value(ary, val)
case val
when Enumerable
val.each{|x| append_field_value(ary, x)}
else
val = val.to_s
if /[\r\n]/.match?(val)
raise ArgumentError, 'header field value cannnot include CR/LF'
end
ary.push val
end
end
# [Ruby 1.8.3]
# Returns an array of header field strings corresponding to the
# case-insensitive +key+. This method allows you to get duplicated