archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-15 13:39:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Refactor vm_lookup_cc to allow lock-free lookups in RClass.cc_tbl

Browse source 
In multi-ractor mode, the `cc_tbl` mutations use the RCU pattern,
which allow lock-less reads.

Based on the assumption that invalidations and misses should be
increasingly rare as the process ages, locking on modification
isn't a big concern.
This commit is contained in:
Jean Boussier 2025-07-30 16:51:59 +02:00
parent f2a7e48dea
commit 547f111b5b
6 changed files with 231 additions and 107 deletions
Download patch file Download diff file Expand all files Collapse all files

17
vm_callinfo.h
View file

@ -330,6 +330,8 @@ cc_check_class(VALUE klass)
}
VALUE rb_vm_cc_table_create(size_t capa);
VALUE rb_vm_cc_table_dup(VALUE old_table);
void rb_vm_cc_table_delete(VALUE table, ID mid);
static inline const struct rb_callcache *
vm_cc_new(VALUE klass,
@ -600,11 +602,14 @@ vm_ccs_p(const struct rb_class_cc_entries *ccs)
static inline bool
vm_cc_check_cme(const struct rb_callcache *cc, const rb_callable_method_entry_t *cme)
{
if (vm_cc_cme(cc) == cme ||
(cme->def->iseq_overload && vm_cc_cme(cc) == rb_vm_lookup_overloaded_cme(cme))) {
bool valid;
RB_VM_LOCKING() {
valid = vm_cc_cme(cc) == cme ||
(cme->def->iseq_overload && vm_cc_cme(cc) == rb_vm_lookup_overloaded_cme(cme));
}
if (valid) {
return true;
}
else {
#if 1
// debug print
@ -616,13 +621,9 @@ vm_cc_check_cme(const struct rb_callcache *cc, const rb_callable_method_entry_t
rp(vm_cc_cme(cc));
rp(rb_vm_lookup_overloaded_cme(cme));
#endif
return false;
}
return false;
}
#endif
// gc.c
void rb_vm_ccs_free(struct rb_class_cc_entries *ccs);
#endif /* RUBY_VM_CALLINFO_H */