mirror of
https://github.com/ruby/ruby.git
synced 2025-08-28 07:26:00 +02:00
Make String methods return String instances when called on a subclass instance
This modifies the following String methods to return String instances instead of subclass instances: * String#* * String#capitalize * String#center * String#chomp * String#chop * String#delete * String#delete_prefix * String#delete_suffix * String#downcase * String#dump * String#each/#each_line * String#gsub * String#ljust * String#lstrip * String#partition * String#reverse * String#rjust * String#rpartition * String#rstrip * String#scrub * String#slice! * String#slice/#[] * String#split * String#squeeze * String#strip * String#sub * String#succ/#next * String#swapcase * String#tr * String#tr_s * String#upcase This also fixes a bug in String#swapcase where it would return the receiver instead of a copy of the receiver if the receiver was the empty string. Some string methods were left to return subclass instances: * String#+@ * String#-@ Both of these methods will return the receiver (subclass instance) in some cases, so it is best to keep the returned class consistent. Fixes [#10845]
This commit is contained in:
parent
4f5d14eb8c
commit
58325daae3
Notes:
git
2020-11-21 09:30:48 +09:00
28 changed files with 591 additions and 211 deletions
|
@ -2089,6 +2089,8 @@ CODE
|
|||
|
||||
def test_swapcase
|
||||
assert_equal(S("hi&LOW"), S("HI&low").swapcase)
|
||||
s = S("")
|
||||
assert_not_same(s, s.swapcase)
|
||||
end
|
||||
|
||||
def test_swapcase!
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue