From 589e2b6782f17d5a1d55021c0395d5d73224e9da Mon Sep 17 00:00:00 2001 From: Hiroshi SHIBATA Date: Thu, 9 Nov 2023 21:45:57 +0900 Subject: [PATCH] [ruby/irb] Revert "Skip TypeCompletion test in ruby ci (https://github.com/ruby/irb/pull/748)" (https://github.com/ruby/irb/pull/755) This reverts commit https://github.com/ruby/irb/commit/d394af0bbce4. https://github.com/ruby/irb/commit/a9d0145115 --- test/irb/test_context.rb | 1 - test/irb/type_completion/test_scope.rb | 2 -- test/irb/type_completion/test_type_analyze.rb | 2 -- test/irb/type_completion/test_type_completor.rb | 2 -- test/irb/type_completion/test_types.rb | 2 -- 5 files changed, 9 deletions(-) diff --git a/test/irb/test_context.rb b/test/irb/test_context.rb index f30ff36d4b..ce57df6cdb 100644 --- a/test/irb/test_context.rb +++ b/test/irb/test_context.rb @@ -653,7 +653,6 @@ module TestIRB end def test_build_completor - pend 'set ENV["WITH_TYPE_COMPLETION_TEST"] to run this test' unless ENV['WITH_TYPE_COMPLETION_TEST'] verbose, $VERBOSE = $VERBOSE, nil original_completor = IRB.conf[:COMPLETOR] IRB.conf[:COMPLETOR] = :regexp diff --git a/test/irb/type_completion/test_scope.rb b/test/irb/type_completion/test_scope.rb index 4eb0194785..d7f9540b06 100644 --- a/test/irb/type_completion/test_scope.rb +++ b/test/irb/type_completion/test_scope.rb @@ -1,7 +1,5 @@ # frozen_string_literal: true -return unless ENV['WITH_TYPE_COMPLETION_TEST'] - return unless RUBY_VERSION >= '3.0.0' return if RUBY_ENGINE == 'truffleruby' # needs endless method definition diff --git a/test/irb/type_completion/test_type_analyze.rb b/test/irb/type_completion/test_type_analyze.rb index 1c1ea94c29..c417a8ad12 100644 --- a/test/irb/type_completion/test_type_analyze.rb +++ b/test/irb/type_completion/test_type_analyze.rb @@ -1,7 +1,5 @@ # frozen_string_literal: true -return unless ENV['WITH_TYPE_COMPLETION_TEST'] - # Run test only when Ruby >= 3.0 and %w[prism rbs] are available return unless RUBY_VERSION >= '3.0.0' return if RUBY_ENGINE == 'truffleruby' # needs endless method definition diff --git a/test/irb/type_completion/test_type_completor.rb b/test/irb/type_completion/test_type_completor.rb index 7ae1ada792..eed400b3e2 100644 --- a/test/irb/type_completion/test_type_completor.rb +++ b/test/irb/type_completion/test_type_completor.rb @@ -1,7 +1,5 @@ # frozen_string_literal: true -return unless ENV['WITH_TYPE_COMPLETION_TEST'] - # Run test only when Ruby >= 3.0 and %w[prism rbs] are available return unless RUBY_VERSION >= '3.0.0' return if RUBY_ENGINE == 'truffleruby' # needs endless method definition diff --git a/test/irb/type_completion/test_types.rb b/test/irb/type_completion/test_types.rb index 93c58be17a..7698bd2fc0 100644 --- a/test/irb/type_completion/test_types.rb +++ b/test/irb/type_completion/test_types.rb @@ -1,7 +1,5 @@ # frozen_string_literal: true -return unless ENV['WITH_TYPE_COMPLETION_TEST'] - return unless RUBY_VERSION >= '3.0.0' return if RUBY_ENGINE == 'truffleruby' # needs endless method definition