archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-15 13:39:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

YJIT: Implement concatarray in yjit (https://github.com/Shopify/ruby/pull/405)

Browse source 
* Create code generation func

* Make rb_vm_concat_array available to use in Rust

* Map opcode to code gen func

* Implement code gen for concatarray

* Add test for concatarray

* Use new asm backend

* Add comment to C func wrapper
This commit is contained in:
Maple Ong 2022-08-15 12:54:26 -04:00 • committed by Takashi Kokubun
parent 2f9df46654
commit 5a76a15a0f
No known key found for this signature in database
GPG key ID: 6FFC433B12EE23DD
4 changed files with 46 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

25
yjit/src/codegen.rs
View file

@ -1256,6 +1256,30 @@ fn gen_splatarray(
KeepCompiling
}
// concat two arrays
fn gen_concatarray(
jit: &mut JITState,
ctx: &mut Context,
asm: &mut Assembler,
_ocb: &mut OutlinedCb,
) -> CodegenStatus {
// Save the PC and SP because the callee may allocate
// Note that this modifies REG_SP, which is why we do it first
jit_prepare_routine_call(jit, ctx, asm);
// Get the operands from the stack
let ary2st_opnd = ctx.stack_pop(1);
let ary1_opnd = ctx.stack_pop(1);
// Call rb_vm_concat_array(ary1, ary2st)
let ary = asm.ccall(rb_vm_concat_array as *const u8, vec![ary1_opnd, ary2st_opnd]);
let stack_ret = ctx.stack_push(Type::Array);
asm.mov(stack_ret, ary);
KeepCompiling
}
// new range initialized from top 2 values
fn gen_newrange(
jit: &mut JITState,
@ -5862,6 +5886,7 @@ fn get_gen_fn(opcode: VALUE) -> Option<InsnGenFn> {
YARVINSN_opt_str_freeze => Some(gen_opt_str_freeze),
YARVINSN_opt_str_uminus => Some(gen_opt_str_uminus),
YARVINSN_splatarray => Some(gen_splatarray),
YARVINSN_concatarray => Some(gen_concatarray),
YARVINSN_newrange => Some(gen_newrange),
YARVINSN_putstring => Some(gen_putstring),
YARVINSN_expandarray => Some(gen_expandarray),