diff --git a/ChangeLog b/ChangeLog index 43ab14f8a5..9f88834908 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +Sun Feb 12 16:53:18 2012 Akinori MUSHA + + * lib/tempfile.rb (Tempfile#unlink, Tempfile::Remover#call): Just + call File.unlink and ignore ENOENT because existence check + before unlinking does not help in terms of race condition. + + * lib/tempfile.rb (Tempfile#unlink, Tempfile::Remover#call): My + comment about thread safeness is obsolete. + Sun Feb 12 16:50:28 2012 Akinori MUSHA * lib/shellwords.rb: Fix rdoc markups. diff --git a/lib/tempfile.rb b/lib/tempfile.rb index 8a517d6746..b34251ebb6 100644 --- a/lib/tempfile.rb +++ b/lib/tempfile.rb @@ -227,18 +227,17 @@ class Tempfile < DelegateClass(File) # # to do so again. # end def unlink - # keep this order for thread safeness return unless @tmpname begin - if File.exist?(@tmpname) - File.unlink(@tmpname) - end - # remove tmpname from remover - @data[0] = @data[1] = nil - @tmpname = nil + File.unlink(@tmpname) + rescue Errno::ENOENT rescue Errno::EACCES # may not be able to unlink on Windows; just ignore + return end + # remove tmpname from remover + @data[0] = @data[1] = nil + @tmpname = nil end alias delete unlink @@ -270,20 +269,22 @@ class Tempfile < DelegateClass(File) end def call(*args) - if @pid == $$ - path, tmpfile = *@data + return if @pid != $$ - STDERR.print "removing ", path, "..." if $DEBUG + path, tmpfile = *@data - tmpfile.close if tmpfile + STDERR.print "removing ", path, "..." if $DEBUG - # keep this order for thread safeness - if path - File.unlink(path) if File.exist?(path) + tmpfile.close if tmpfile + + if path + begin + File.unlink(path) + rescue Errno::ENOENT end - - STDERR.print "done\n" if $DEBUG end + + STDERR.print "done\n" if $DEBUG end end # :startdoc: diff --git a/version.h b/version.h index 6c23f88770..46cd6b30b6 100644 --- a/version.h +++ b/version.h @@ -1,5 +1,5 @@ #define RUBY_VERSION "1.9.3" -#define RUBY_PATCHLEVEL 100 +#define RUBY_PATCHLEVEL 101 #define RUBY_RELEASE_DATE "2012-02-12" #define RUBY_RELEASE_YEAR 2012