archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-15 13:39:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

rb_setup_fake_ary: use precomputed flags

Browse source 
Setting up the fake array is a bit more expensive than would be
expected because `rb_ary_freeze` does a lot of checks and lookup
a shape transition.

If we assume fake arrays will always be frozen, we can precompute
the flags state and just assign it.
This commit is contained in:
Jean Boussier 2024-08-08 14:11:37 +02:00
parent 7b7dde37f5
commit 6ee9a08d32
Notes: git 2024-08-10 08:09:32 +00:00
2 changed files with 26 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

34
array.c
View file

@ -892,17 +892,29 @@ rb_ary_free(VALUE ary)
}
}
VALUE
rb_setup_fake_ary(struct RArray *fake_ary, const VALUE *list, long len, bool freeze)
static VALUE fake_ary_flags;
static VALUE
init_fake_ary_flags(void)
{
fake_ary->basic.flags = T_ARRAY;
VALUE ary = (VALUE)fake_ary;
RBASIC_CLEAR_CLASS(ary);
ARY_SET_PTR(ary, list);
ARY_SET_HEAP_LEN(ary, len);
ARY_SET_CAPA(ary, len);
if (freeze) rb_ary_freeze(ary);
return ary;
struct RArray fake_ary = {0};
fake_ary.basic.flags = T_ARRAY;
VALUE ary = (VALUE)&fake_ary;
rb_ary_freeze(ary);
return fake_ary.basic.flags;
}
VALUE
rb_setup_fake_ary(struct RArray *fake_ary, const VALUE *list, long len)
{
fake_ary->basic.flags = fake_ary_flags;
RBASIC_CLEAR_CLASS((VALUE)fake_ary);
// bypass frozen checks
fake_ary->as.heap.ptr = list;
fake_ary->as.heap.len = len;
fake_ary->as.heap.aux.capa = len;
return (VALUE)fake_ary;
}
size_t
@ -8677,6 +8689,8 @@ rb_ary_deconstruct(VALUE ary)
void
Init_Array(void)
{
fake_ary_flags = init_fake_ary_flags();
rb_cArray = rb_define_class("Array", rb_cObject);
rb_include_module(rb_cArray, rb_mEnumerable);