From 763e41cbcaad0f3feab7bf54133171b79c78a66c Mon Sep 17 00:00:00 2001 From: suke Date: Tue, 28 Aug 2007 14:16:24 +0000 Subject: [PATCH] * ext/win32ole/win32ole.c (ole_type_progid, reg_enum_key, reg_get_val, ole_wc2mb): fix the bug. Thanks, arton. [ruby-dev:31576] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8@13297 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 6 ++++++ ext/win32ole/win32ole.c | 21 +++++++++++++-------- version.h | 6 +++--- 3 files changed, 22 insertions(+), 11 deletions(-) diff --git a/ChangeLog b/ChangeLog index 0b7b1acbd6..4bf3433bc8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +Tue Aug 28 23:26:12 2007 Masaki Suketa + + * ext/win32ole/win32ole.c (ole_type_progid, reg_enum_key, + reg_get_val, ole_wc2mb): fix the bug. Thanks, arton. + [ruby-dev:31576] + Mon Aug 27 19:10:50 2007 Yukihiro Matsumoto * ext/etc/etc.c (etc_getlogin): update documentation to note diff --git a/ext/win32ole/win32ole.c b/ext/win32ole/win32ole.c index dace9df806..a2cac84cb7 100644 --- a/ext/win32ole/win32ole.c +++ b/ext/win32ole/win32ole.c @@ -79,7 +79,7 @@ #define WC2VSTR(x) ole_wc2vstr((x), TRUE) -#define WIN32OLE_VERSION "0.7.1" +#define WIN32OLE_VERSION "0.7.2" typedef HRESULT (STDAPICALLTYPE FNCOCREATEINSTANCEEX) (REFCLSID, IUnknown*, DWORD, COSERVERINFO*, DWORD, MULTI_QI*); @@ -477,8 +477,9 @@ ole_wc2mb(pw) LPSTR pm; size = WideCharToMultiByte(cWIN32OLE_cp, 0, pw, -1, NULL, 0, NULL, NULL); if (size) { - pm = ALLOC_N(char, size); + pm = ALLOC_N(char, size + 1); WideCharToMultiByte(cWIN32OLE_cp, 0, pw, -1, pm, size, NULL, NULL); + pm[size] = '\0'; } else { pm = ALLOC_N(char, 1); @@ -1138,12 +1139,13 @@ reg_enum_key(hkey, i) HKEY hkey; DWORD i; { - char buf[BUFSIZ]; - DWORD size_buf = sizeof(buf); + char buf[BUFSIZ + 1]; + DWORD size_buf = sizeof(buf) - 1; FILETIME ft; LONG err = RegEnumKeyEx(hkey, i, buf, &size_buf, NULL, NULL, NULL, &ft); if(err == ERROR_SUCCESS) { + buf[BUFSIZ] = '\0'; return rb_str_new2(buf); } return Qnil; @@ -1154,10 +1156,11 @@ reg_get_val(hkey, subkey) HKEY hkey; const char *subkey; { - char buf[BUFSIZ]; - LONG size_buf = sizeof(buf); + char buf[BUFSIZ + 1]; + LONG size_buf = sizeof(buf) - 1; LONG err = RegQueryValue(hkey, subkey, buf, &size_buf); if (err == ERROR_SUCCESS) { + buf[BUFSIZ] = '\0'; return rb_str_new2(buf); } return Qnil; @@ -3618,8 +3621,10 @@ ole_type_progid(pTypeInfo) if (FAILED(hr)) return progid; hr = ProgIDFromCLSID(&pTypeAttr->guid, &pbuf); - if (SUCCEEDED(hr)) - progid = WC2VSTR(pbuf); + if (SUCCEEDED(hr)) { + progid = ole_wc2vstr(pbuf, FALSE); + CoTaskMemFree(pbuf); + } OLE_RELEASE_TYPEATTR(pTypeInfo, pTypeAttr); return progid; } diff --git a/version.h b/version.h index ba16b07567..ac88728ac3 100644 --- a/version.h +++ b/version.h @@ -1,7 +1,7 @@ #define RUBY_VERSION "1.8.6" -#define RUBY_RELEASE_DATE "2007-08-27" +#define RUBY_RELEASE_DATE "2007-08-28" #define RUBY_VERSION_CODE 186 -#define RUBY_RELEASE_CODE 20070827 +#define RUBY_RELEASE_CODE 20070828 #define RUBY_PATCHLEVEL 5000 #define RUBY_VERSION_MAJOR 1 @@ -9,7 +9,7 @@ #define RUBY_VERSION_TEENY 6 #define RUBY_RELEASE_YEAR 2007 #define RUBY_RELEASE_MONTH 8 -#define RUBY_RELEASE_DAY 27 +#define RUBY_RELEASE_DAY 28 #ifdef RUBY_EXTERN RUBY_EXTERN const char ruby_version[];