archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-09-15 16:44:01 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[ruby/pp] Handle BasicObject

Browse source 
Right now attempting to pretty print a BasicObject or any other
object lacking a few core Object methods will result in an error

```
Error: test_basic_object(PPTestModule::PPInspectTest): NoMethodError: undefined method `is_a?' for an instance of BasicObject
lib/pp.rb:192:in `pp'
lib/pp.rb:97:in `block in pp'
lib/pp.rb:158:in `guard_inspect_key'
lib/pp.rb:97:in `pp'
test/test_pp.rb:131:in `test_basic_object'
     128:
     129:   def test_basic_object
     130:     a = BasicObject.new
  => 131:     assert_match(/\A#<BasicObject:0x[\da-f]+>\n\z/, PP.pp(a, ''.dup))
     132:   end
     133: end
     134:
```

With some fairly small changes we can fallback to `Object#inspect`
which is better than an error.

4e9f6c2de0
This commit is contained in:
Jean Boussier 2024-07-12 12:23:24 +02:00 • committed by git
parent 107a4da122
commit 83702f7157
2 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/pp.rb
View file

@ -189,7 +189,7 @@ class PP < PrettyPrint
def pp(obj) def pp(obj)
# If obj is a Delegator then use the object being delegated to for cycle # If obj is a Delegator then use the object being delegated to for cycle
# detection # detection
obj = obj.__getobj__ if defined?(::Delegator) and obj.is_a?(::Delegator) obj = obj.__getobj__ if defined?(::Delegator) and ::Delegator === obj
if check_inspect_key(obj) if check_inspect_key(obj)
group {obj.pretty_print_cycle self} group {obj.pretty_print_cycle self}
@ -198,7 +198,11 @@ class PP < PrettyPrint
begin begin
push_inspect_key(obj) push_inspect_key(obj)
group {obj.pretty_print self} group do
obj.pretty_print self
rescue NoMethodError
text Kernel.instance_method(:inspect).bind_call(obj)
end
ensure ensure
pop_inspect_key(obj) unless PP.sharing_detection pop_inspect_key(obj) unless PP.sharing_detection
end end

5
test/test_pp.rb
View file

@ -125,6 +125,11 @@ class PPInspectTest < Test::Unit::TestCase
result = PP.pp(a, ''.dup) result = PP.pp(a, ''.dup)
assert_equal("#{a.inspect}\n", result) assert_equal("#{a.inspect}\n", result)
end end
def test_basic_object
a = BasicObject.new
assert_match(/\A#<BasicObject:0x[\da-f]+>\n\z/, PP.pp(a, ''.dup))
end
end end
class PPCycleTest < Test::Unit::TestCase class PPCycleTest < Test::Unit::TestCase