archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-09-22 03:53:58 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Add sign-extended mode for test() instruction

Browse source
This commit is contained in:
Maxime Chevalier-Boisvert 2020-12-14 13:26:33 -05:00 • committed by Alan Wu
parent 8ae354e9be
commit 868a6809e7
2 changed files with 24 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

34
ujit_asm.c
View file

@ -1516,22 +1516,34 @@ void test(codeblock_t* cb, x86opnd_t rm_opnd, x86opnd_t test_opnd)
if (test_opnd.type == OPND_IMM) if (test_opnd.type == OPND_IMM)
{ {
x86opnd_t imm_opnd = test_opnd; x86opnd_t imm_opnd = test_opnd;
assert (imm_opnd.as.imm >= 0);
assert (unsig_imm_size(imm_opnd.as.unsig_imm) <= 32);
assert (unsig_imm_size(imm_opnd.as.unsig_imm) <= rm_opnd.num_bits);
// Use the smallest operand size possible if (imm_opnd.as.imm >= 0)
rm_opnd = resize_opnd(rm_opnd, unsig_imm_size(imm_opnd.as.unsig_imm));
if (rm_opnd.num_bits == 8)
{ {
cb_write_rm(cb, false, false, NO_OPND, rm_opnd, 0x00, 1, 0xF6); assert (unsig_imm_size(imm_opnd.as.unsig_imm) <= 32);
cb_write_int(cb, imm_opnd.as.imm, rm_opnd.num_bits); assert (unsig_imm_size(imm_opnd.as.unsig_imm) <= rm_opnd.num_bits);
// Use the smallest operand size possible
rm_opnd = resize_opnd(rm_opnd, unsig_imm_size(imm_opnd.as.unsig_imm));
if (rm_opnd.num_bits == 8)
{
cb_write_rm(cb, false, false, NO_OPND, rm_opnd, 0x00, 1, 0xF6);
cb_write_int(cb, imm_opnd.as.imm, rm_opnd.num_bits);
}
else
{
cb_write_rm(cb, rm_opnd.num_bits == 16, false, NO_OPND, rm_opnd, 0x00, 1, 0xF7);
cb_write_int(cb, imm_opnd.as.imm, rm_opnd.num_bits);
}
} }
else else
{ {
cb_write_rm(cb, rm_opnd.num_bits == 16, false, NO_OPND, rm_opnd, 0x00, 1, 0xF7); // This mode only applies to 64-bit R/M operands with 32-bit signed immediates
cb_write_int(cb, imm_opnd.as.imm, rm_opnd.num_bits); assert (imm_opnd.as.imm < 0);
assert (sig_imm_size(imm_opnd.as.imm) <= 32);
assert (rm_opnd.num_bits == 64);
cb_write_rm(cb, false, true, NO_OPND, rm_opnd, 0x00, 1, 0xF7);
cb_write_int(cb, imm_opnd.as.imm, 32);
} }
} }
else else

1
ujit_asm_tests.c
View file

@ -315,6 +315,7 @@ void run_tests()
cb_set_pos(cb, 0); test(cb, mem_opnd(8, RSI, 16), imm_opnd(1)); check_bytes(cb, "F6461001"); cb_set_pos(cb, 0); test(cb, mem_opnd(8, RSI, 16), imm_opnd(1)); check_bytes(cb, "F6461001");
cb_set_pos(cb, 0); test(cb, mem_opnd(8, RSI, -16), imm_opnd(1)); check_bytes(cb, "F646F001"); cb_set_pos(cb, 0); test(cb, mem_opnd(8, RSI, -16), imm_opnd(1)); check_bytes(cb, "F646F001");
cb_set_pos(cb, 0); test(cb, mem_opnd(32, RSI, 64), EAX); check_bytes(cb, "854640"); cb_set_pos(cb, 0); test(cb, mem_opnd(32, RSI, 64), EAX); check_bytes(cb, "854640");
cb_set_pos(cb, 0); test(cb, mem_opnd(64, RSI, 64), imm_opnd(~0x08)); check_bytes(cb, "48F74640F7FFFFFF");
// xor // xor
cb_set_pos(cb, 0); xor(cb, EAX, EAX); check_bytes(cb, "31C0"); cb_set_pos(cb, 0); xor(cb, EAX, EAX); check_bytes(cb, "31C0");