mirror of
https://github.com/ruby/ruby.git
synced 2025-09-15 16:44:01 +02:00
CI: Surface Rust warnings on PRs that touch any Rust code
Rust PRs will have a failed CI step if they trigger any warnings. This helps us stay on top of warnings from new Rust releases and also ones we accidentally write. Fix a typo for demo, since this only runs when Rust files are changed.
This commit is contained in:
parent
0070c26aec
commit
8b1afbc6ed
2 changed files with 54 additions and 1 deletions
53
.github/workflows/rust-warnings.yml
vendored
Normal file
53
.github/workflows/rust-warnings.yml
vendored
Normal file
|
@ -0,0 +1,53 @@
|
||||||
|
# Surface Rust warnings on PRs that touch any Rust code.
|
||||||
|
# Not a required check so we never block people over new warnings
|
||||||
|
# that might come from a new Rust version being released.
|
||||||
|
name: Rust warnings
|
||||||
|
on:
|
||||||
|
pull_request:
|
||||||
|
types:
|
||||||
|
- opened
|
||||||
|
- synchronize
|
||||||
|
- reopened
|
||||||
|
paths:
|
||||||
|
- '**.rs'
|
||||||
|
- '!**.inc.rs'
|
||||||
|
merge_group:
|
||||||
|
|
||||||
|
concurrency:
|
||||||
|
group: ${{ github.workflow }} / ${{ startsWith(github.event_name, 'pull') && github.ref_name || github.sha }}
|
||||||
|
cancel-in-progress: ${{ startsWith(github.event_name, 'pull') }}
|
||||||
|
|
||||||
|
permissions:
|
||||||
|
contents: read
|
||||||
|
|
||||||
|
jobs:
|
||||||
|
make:
|
||||||
|
env:
|
||||||
|
GITPULLOPTIONS: --no-tags origin ${{ github.ref }}
|
||||||
|
|
||||||
|
runs-on: ubuntu-24.04
|
||||||
|
|
||||||
|
if: >-
|
||||||
|
${{!(false
|
||||||
|
|| contains(github.event.head_commit.message, '[DOC]')
|
||||||
|
|| contains(github.event.head_commit.message, 'Document')
|
||||||
|
|| contains(github.event.pull_request.title, '[DOC]')
|
||||||
|
|| contains(github.event.pull_request.title, 'Document')
|
||||||
|
|| contains(github.event.pull_request.labels.*.name, 'Documentation')
|
||||||
|
|| (github.event_name == 'push' && github.event.pull_request.user.login == 'dependabot[bot]')
|
||||||
|
)}}
|
||||||
|
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
|
||||||
|
|
||||||
|
- name: Install Rust
|
||||||
|
run: rustup default beta
|
||||||
|
|
||||||
|
- name: Rust warnings
|
||||||
|
run: |
|
||||||
|
set -euo pipefail
|
||||||
|
cargo check --quiet --all-features --message-format=json \
|
||||||
|
| jq -r 'select(.reason == "compiler-message" and .message.level == "warning") | .message.rendered' \
|
||||||
|
> warnings.txt
|
||||||
|
cat warnings.txt
|
||||||
|
! grep --quiet '[^[:space:]]' warnings.txt
|
|
@ -343,7 +343,7 @@ impl<'a> std::fmt::Display for ConstPrinter<'a> {
|
||||||
///
|
///
|
||||||
/// Because this is extra state external to any pointer being printed, a
|
/// Because this is extra state external to any pointer being printed, a
|
||||||
/// printing adapter struct that wraps the pointer along with this map is
|
/// printing adapter struct that wraps the pointer along with this map is
|
||||||
/// required to make use of this effectly. The [`std::fmt::Display`]
|
/// required to make use of this effectively. The [`std::fmt::Display`]
|
||||||
/// implementation on the adapter struct can then be reused to implement
|
/// implementation on the adapter struct can then be reused to implement
|
||||||
/// `Display` on the inner type with a default [`PtrPrintMap`], which
|
/// `Display` on the inner type with a default [`PtrPrintMap`], which
|
||||||
/// does not perform any mapping.
|
/// does not perform any mapping.
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue