archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-15 13:39:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[Bug #21106] Remove the useless last iteration

Browse source 
When only one element remains, this simply swaps the first identical
element and has no actual effect.
This commit is contained in:
Nobuyoshi Nakada 2025-02-02 19:34:52 +09:00
parent ace39a3ed4
commit 8dd0d63550
No known key found for this signature in database
GPG key ID: 3582D74E1FEE4465
Notes: git 2025-02-02 16:19:09 +00:00
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
array.c
View file

@ -6701,7 +6701,7 @@ rb_ary_shuffle_bang(rb_execution_context_t *ec, VALUE ary, VALUE randgen)
rb_ary_modify(ary);
i = len = RARRAY_LEN(ary);
RARRAY_PTR_USE(ary, ptr, {
while (i) {
while (i > 1) {
long j = RAND_UPTO(i);
VALUE tmp;
if (len != RARRAY_LEN(ary) || ptr != RARRAY_CONST_PTR(ary)) {