From 99a147ff4fbfda6f15d8b6bcfd61d5776a58be2b Mon Sep 17 00:00:00 2001 From: Kevin Newton Date: Thu, 30 Nov 2023 12:52:42 -0500 Subject: [PATCH] [ruby/prism] Document remaining encodings https://github.com/ruby/prism/commit/b9510aed40 --- prism/encoding.c | 2 +- prism/encoding.h | 3 +-- test/prism/library_symbols_test.rb | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/prism/encoding.c b/prism/encoding.c index 2141eb2948..4bf6b6a775 100644 --- a/prism/encoding.c +++ b/prism/encoding.c @@ -4214,7 +4214,7 @@ pm_encoding_shift_jis_char_width(const uint8_t *b, ptrdiff_t n) { /** * This is the definition of all of the encodings that we support. */ -static const pm_encoding_t pm_encodings[PM_ENCODING_MAXIMUM] = { +static const pm_encoding_t pm_encodings[] = { [PM_ENCODING_UTF_8] = { .name = "UTF-8", .char_width = pm_encoding_utf_8_char_width, diff --git a/prism/encoding.h b/prism/encoding.h index dd60c620eb..247db600ce 100644 --- a/prism/encoding.h +++ b/prism/encoding.h @@ -213,8 +213,7 @@ typedef enum { PM_ENCODING_WINDOWS_1257, PM_ENCODING_WINDOWS_1258, PM_ENCODING_WINDOWS_31J, - PM_ENCODING_WINDOWS_874, - PM_ENCODING_MAXIMUM + PM_ENCODING_WINDOWS_874 } pm_encoding_type_t; /** diff --git a/test/prism/library_symbols_test.rb b/test/prism/library_symbols_test.rb index d8eb96e257..4a4d35b2c7 100644 --- a/test/prism/library_symbols_test.rb +++ b/test/prism/library_symbols_test.rb @@ -84,7 +84,7 @@ module Prism assert_includes(symbols, "pm_version") end names(local_nm_symbols(@libprism_so)).tap do |symbols| - assert_includes(symbols, "pm_encoding_shift_jis_isupper_char") + assert_includes(symbols, "pm_encoding_utf_8_isupper_char") end # TODO: someone who uses this library needs to finish this test end