archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-24 21:44:30 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[ruby/irb] Stop using MagicFile for printing help messages

Browse source 
(https://github.com/ruby/irb/pull/573)

`MagicFile` was introduced around v0.9.6, which was like 14~15 years ago.
It was needed because back then we needed to read a file's magic comment
to determine the encoding of it, and read it with that encoding.

Commit: 3ee79e89ad

But now both EN and JA's help-message file are UTF-8 and have removed the
encoding comment, we don't need to open them with `MagicFile` anymore.
This commit is contained in:
Stan Lo 2023-04-27 12:07:01 +01:00 • committed by git
parent c7bacf84f0
commit a58cae77f7
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/irb/help.rb
View file

@ -12,7 +12,7 @@ module IRB
lc = IRB.conf[:LC_MESSAGES] lc = IRB.conf[:LC_MESSAGES]
path = lc.find("irb/help-message") path = lc.find("irb/help-message")
space_line = false space_line = false
IRB::MagicFile.open(path){|f| File.open(path){|f|
f.each_line do |l| f.each_line do |l|
if /^\s*$/ =~ l if /^\s*$/ =~ l
lc.puts l unless space_line lc.puts l unless space_line