archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-09-22 20:14:02 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fix Enumerable#tally with some arguments pattern [Feature #17744]

Browse source 
* Add test cases for Enumerable#tally with hash argument

* Add ruby/spec for Enumerable#tally with hash argument

* Fix Enumerable#tally does not update given frozen hash

* Add test cases for Enumerable#tally with hash convertible arguments

* Fix SEGV when Enumerable#tally takes non Hash convertible

* FIx cosmetic damage enum.c
This commit is contained in:
Kenichi Kamiya 2021-03-27 12:55:46 +09:00 • committed by GitHub
parent 785c77d782
commit aceb8c0b4b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
Notes: git 2021-03-27 12:56:06 +09:00 
Merged: https://github.com/ruby/ruby/pull/4327

Merged-By: nobu <nobu@ruby-lang.org>
3 changed files with 54 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

28
test/ruby/test_enum.rb
View file

@ -402,6 +402,34 @@ class TestEnumerable < Test::Unit::TestCase
@obj.tally({1 => ""})
end
h = {1 => 2, 2 => 2, 3 => 1}
assert_same(h, @obj.tally(h))
h = {1 => 2, 2 => 2, 3 => 1}.freeze
assert_raise(FrozenError) do
@obj.tally(h)
end
assert_equal({1 => 2, 2 => 2, 3 => 1}, h)
hash_convertible = Object.new
def hash_convertible.to_hash
{1 => 3, 4 => "x"}
end
assert_equal({1 => 5, 2 => 2, 3 => 1, 4 => "x"}, @obj.tally(hash_convertible))
hash_convertible = Object.new
def hash_convertible.to_hash
{1 => 3, 4 => "x"}.freeze
end
assert_raise(FrozenError) do
@obj.tally(hash_convertible)
end
assert_equal({1 => 3, 4 => "x"}, hash_convertible.to_hash)
assert_raise(TypeError) do
@obj.tally(BasicObject.new)
end
h = {1 => 2, 2 => 2, 3 => 1}
assert_equal(h, @obj.tally(Hash.new(100)))
assert_equal(h, @obj.tally(Hash.new {100}))