archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-26 22:45:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

[ruby/yarp] fix: heredoc with incomplete escape at end of file

Browse source 
Previously this resulted in invalid memory access.

Found by the fuzzer.

ec4abd87f4
This commit is contained in:
Mike Dalessio 2023-08-30 13:52:03 -04:00 • committed by git
parent 341f47a6dd
commit ae7f907559
2 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
test/yarp/fuzzer_test.rb
View file

@ -23,4 +23,5 @@ class FuzzerTest < Test::Unit::TestCase
snippet "incomplete hex number", "0x"
snippet "incomplete escaped list", "%w[\\"
snippet "incomplete escaped regex", "/a\\"
snippet "unterminated heredoc with unterminated escape at end of file", "<<A\n\\"
end

6
yarp/yarp.c
View file

@ -7413,6 +7413,12 @@ parser_lex(yp_parser_t *parser) {
break;
}
case '\\': {
// Check that we're not at the end of the file.
if (breakpoint + 1 >= parser->end) {
breakpoint = NULL;
break;
}
// If we hit an escape, then we need to skip past
// however many characters the escape takes up. However
// it's important that if \n or \r\n are escaped that we