[rubygems/rubygems] Move Bundler::Fetcher::HTTP_ERRORS to Bundler::Fetcher::DOWNLOADER

And deprecate the old constant.

It's only used in this class, and in Bundler::Fetcher there's already
FAIL_ERRORS, very similar to it. So this makes things less confusing.

d32ed63d6f

lib/bundler/fetcher.rb

@@ -72,24 +72,8 @@ module Bundler
       end
     end
 
-    HTTP_ERRORS = [
+    HTTP_ERRORS = Downloader::HTTP_ERRORS
-      Gem::Timeout::Error,
+    deprecate_constant :HTTP_ERRORS
-      EOFError,
-      SocketError,
-      Errno::EADDRNOTAVAIL,
-      Errno::ENETDOWN,
-      Errno::ENETUNREACH,
-      Errno::EINVAL,
-      Errno::ECONNRESET,
-      Errno::ETIMEDOUT,
-      Errno::EAGAIN,
-      Gem::Net::HTTPBadResponse,
-      Gem::Net::HTTPHeaderSyntaxError,
-      Gem::Net::ProtocolError,
-      Gem::Net::HTTP::Persistent::Error,
-      Zlib::BufError,
-      Errno::EHOSTUNREACH,
-    ].freeze
 
     NET_ERRORS = [
       :HTTPBadGateway,

lib/bundler/fetcher/downloader.rb

@@ -3,6 +3,25 @@
 module Bundler
   class Fetcher
     class Downloader
+      HTTP_ERRORS = [
+        Gem::Timeout::Error,
+        EOFError,
+        SocketError,
+        Errno::EADDRNOTAVAIL,
+        Errno::ENETDOWN,
+        Errno::ENETUNREACH,
+        Errno::EINVAL,
+        Errno::ECONNRESET,
+        Errno::ETIMEDOUT,
+        Errno::EAGAIN,
+        Gem::Net::HTTPBadResponse,
+        Gem::Net::HTTPHeaderSyntaxError,
+        Gem::Net::ProtocolError,
+        Gem::Net::HTTP::Persistent::Error,
+        Zlib::BufError,
+        Errno::EHOSTUNREACH,
+      ].freeze
+
       attr_reader :connection
       attr_reader :redirect_limit
 

spec/bundler/bundler/fetcher/downloader_spec.rb

@@ -206,7 +206,7 @@ RSpec.describe Bundler::Fetcher::Downloader do
       let(:error)   { RuntimeError.new(message) }
 
       before do
-        stub_const("Bundler::Fetcher::HTTP_ERRORS", [RuntimeError])
+        stub_const("#{described_class}::HTTP_ERRORS", [RuntimeError])
         allow(connection).to receive(:request).with(uri, net_http_get) { raise error }
       end