archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-09-22 03:53:58 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Remove offset: from Array#pack

Browse source 
* pack.c (pack_pack): can use `@` instead of `offset:`.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@56958 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
usa 2016-12-01 13:20:47 +00:00
parent 0dd9c302d9
commit b6e137e93c
3 changed files with 11 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

13
test/ruby/test_pack.rb
View file

@ -816,18 +816,9 @@ EXPECTED
def test_pack_with_buffer
buf = String.new(capacity: 100)
assert_raise_with_message(ArgumentError, /without buffer/) {
[0xDEAD_BEEF].pack('N', offset: 10)
}
assert_raise_with_message(ArgumentError, /too small/) {
[0xDEAD_BEEF].pack('N', buffer: buf, offset: 200)
}
assert_raise_with_message(RuntimeError, /frozen/) {
[0xDEAD_BEEF].pack('N', buffer: 'foo'.freeze)
}
assert_raise_with_message(TypeError, /into Integer/) {
[0xDEAD_BEEF].pack('N', buffer: buf, offset: '10')
}
assert_raise_with_message(TypeError, /must be String/) {
[0xDEAD_BEEF].pack('N', buffer: Object.new)
}
@ -837,11 +828,11 @@ EXPECTED
[0xDEAD_BEEF].pack('N', buffer: buf)
assert_equal "\xDE\xAD\xBE\xEF", buf
[0xBABE_F00D].pack('N', buffer: buf, offset: 4)
[0xBABE_F00D].pack('@4N', buffer: buf)
assert_equal "\xDE\xAD\xBE\xEF\xBA\xBE\xF0\x0D", buf
assert_equal addr, [buf].pack('p')
[0xBAAD_FACE].pack('N', buffer: buf, offset: 10)
[0xBAAD_FACE].pack('@10N', buffer: buf)
assert_equal "\xDE\xAD\xBE\xEF\xBA\xBE\xF0\x0D\0\0\xBA\xAD\xFA\xCE", buf
assert_equal addr, [buf].pack('p')