From c67f6c4dafbc868c36b3e021331fe0b1fac680f5 Mon Sep 17 00:00:00 2001 From: Michael Siegfried Date: Wed, 16 Nov 2022 16:13:06 -0800 Subject: [PATCH] [rubygems/rubygems] Add question marks to interrogative methods https://github.com/rubygems/rubygems/commit/52da85e9ef --- lib/bundler/gem_version_promoter.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/bundler/gem_version_promoter.rb b/lib/bundler/gem_version_promoter.rb index d6ae65998f..f3a7ed7787 100644 --- a/lib/bundler/gem_version_promoter.rb +++ b/lib/bundler/gem_version_promoter.rb @@ -100,11 +100,11 @@ module Bundler if major? a <=> b - elsif either_version_older_than_locked(a, b, locked_version) + elsif either_version_older_than_locked?(a, b, locked_version) a <=> b - elsif segments_do_not_match(a, b, :major) + elsif segments_do_not_match?(a, b, :major) b <=> a - elsif !minor? && segments_do_not_match(a, b, :minor) + elsif !minor? && segments_do_not_match?(a, b, :minor) b <=> a else a <=> b @@ -113,11 +113,11 @@ module Bundler post_sort(result, package.unlock?, locked_version) end - def either_version_older_than_locked(a, b, locked_version) + def either_version_older_than_locked?(a, b, locked_version) locked_version && (a.version < locked_version || b.version < locked_version) end - def segments_do_not_match(a, b, level) + def segments_do_not_match?(a, b, level) index = [:major, :minor].index(level) a.segments[index] != b.segments[index] end