From c690ca03f33441f299d0b59e4a91fc22bf1781bf Mon Sep 17 00:00:00 2001 From: Nobuyoshi Nakada Date: Wed, 6 Nov 2024 11:03:48 +0900 Subject: [PATCH] Ignore return value of `into_raw_fd` Fix as the compiler orders: ``` warning: unused return value of `into_raw_fd` that must be used --> ../src/yjit/src/disasm.rs:123:21 | 123 | file.into_raw_fd(); // keep the fd open | ^^^^^^^^^^^^^^^^^^ | = note: losing the raw file descriptor may leak resources = note: `#[warn(unused_must_use)]` on by default help: use `let _ = ...` to ignore the resulting value | 123 | let _ = file.into_raw_fd(); // keep the fd open | +++++++ warning: unused return value of `into_raw_fd` that must be used --> ../src/yjit/src/log.rs:84:21 | 84 | file.into_raw_fd(); // keep the fd open | ^^^^^^^^^^^^^^^^^^ | = note: losing the raw file descriptor may leak resources help: use `let _ = ...` to ignore the resulting value | 84 | let _ = file.into_raw_fd(); // keep the fd open | +++++++ ``` --- yjit/src/disasm.rs | 2 +- yjit/src/log.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/yjit/src/disasm.rs b/yjit/src/disasm.rs index 89da07beda..f98a3645fb 100644 --- a/yjit/src/disasm.rs +++ b/yjit/src/disasm.rs @@ -120,7 +120,7 @@ pub fn dump_disasm_addr_range(cb: &CodeBlock, start_addr: CodePtr, end_addr: Cod // Write with the fd opened during boot let mut file = unsafe { std::fs::File::from_raw_fd(*fd) }; file.write_all(disasm.as_bytes()).unwrap(); - file.into_raw_fd(); // keep the fd open + let _ = file.into_raw_fd(); // keep the fd open } }; } diff --git a/yjit/src/log.rs b/yjit/src/log.rs index f2dcf519e0..c5a724f7e1 100644 --- a/yjit/src/log.rs +++ b/yjit/src/log.rs @@ -81,7 +81,7 @@ impl Log { let mut file = unsafe { std::fs::File::from_raw_fd(fd) }; writeln!(file, "{}", entry).unwrap(); file.flush().unwrap(); - file.into_raw_fd(); // keep the fd open + let _ = file.into_raw_fd(); // keep the fd open } LogOutput::MemoryOnly => () // Don't print or write anything