diff --git a/ChangeLog b/ChangeLog index eaa5d11a7b..52e5b9d0c0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +Mon Apr 15 00:15:04 2013 Nobuyoshi Nakada + + * class.c (HAVE_METACLASS_P): should check FL_SINGLETON flag before get + instance variable to get rid of wrong warning about __attached__. + [ruby-core:53839] [Bug #8188] + Mon Apr 15 00:13:13 2013 NAKAMURA Usaku * win32/file.c (code_page): use cp1252 instead of cp20127 as US-ASCII. diff --git a/class.c b/class.c index b8e47df8f2..85ce5b88bb 100644 --- a/class.c +++ b/class.c @@ -307,6 +307,14 @@ rb_singleton_class_attached(VALUE klass, VALUE obj) */ #define META_CLASS_OF_CLASS_CLASS_P(k) (METACLASS_OF(k) == (k)) +/*! + * whether k has a metaclass + * @retval 1 if \a k has a metaclass + * @retval 0 otherwise + */ +#define HAVE_METACLASS_P(k) \ + (FL_TEST(METACLASS_OF(k), FL_SINGLETON) && \ + rb_ivar_get(METACLASS_OF(k), id_attached) == (k)) /*! * ensures \a klass belongs to its own eigenclass. @@ -316,7 +324,7 @@ rb_singleton_class_attached(VALUE klass, VALUE obj) * @note this macro creates a new eigenclass if necessary. */ #define ENSURE_EIGENCLASS(klass) \ - (rb_ivar_get(METACLASS_OF(klass), id_attached) == (klass) ? METACLASS_OF(klass) : make_metaclass(klass)) + (HAVE_METACLASS_P(klass) ? METACLASS_OF(klass) : make_metaclass(klass)) /*! diff --git a/test/ruby/test_eval.rb b/test/ruby/test_eval.rb index 580d3e88b1..a97b982246 100644 --- a/test/ruby/test_eval.rb +++ b/test/ruby/test_eval.rb @@ -215,6 +215,13 @@ class TestEval < Test::Unit::TestCase end end + def test_instance_eval_on_argf_singleton_class + bug8188 = '[ruby-core:53839] [Bug #8188]' + assert_warning('', bug8188) do + ARGF.singleton_class.instance_eval{} + end + end + class Foo Bar = 2 end diff --git a/version.h b/version.h index 85d00bd7e6..7522190385 100644 --- a/version.h +++ b/version.h @@ -1,6 +1,6 @@ #define RUBY_VERSION "2.0.0" #define RUBY_RELEASE_DATE "2013-04-15" -#define RUBY_PATCHLEVEL 129 +#define RUBY_PATCHLEVEL 130 #define RUBY_RELEASE_YEAR 2013 #define RUBY_RELEASE_MONTH 4