archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-15 13:39:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Use reference counting to avoid memory leak in kwargs

Browse source 
Tracks other callinfo that references the same kwargs and frees them when all references are cleared.

[bug #19906]

Co-authored-by: Peter Zhu <peter@peterzhu.ca>
This commit is contained in:
HParker 2023-09-29 14:06:26 -07:00 • committed by Peter Zhu
parent be09c8370b
commit c74dc8b4af
4 changed files with 18 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
vm_callinfo.h
View file

@ -43,6 +43,7 @@ enum vm_call_flag_bits {
struct rb_callinfo_kwarg {
int keyword_len;
int references;
VALUE keywords[];
};
@ -199,6 +200,9 @@ vm_ci_dump(const struct rb_callinfo *ci)
static inline const struct rb_callinfo *
vm_ci_new_(ID mid, unsigned int flag, unsigned int argc, const struct rb_callinfo_kwarg *kwarg, const char *file, int line)
{
if (kwarg) {
((struct rb_callinfo_kwarg *)kwarg)->references++;
}
if (USE_EMBED_CI && VM_CI_EMBEDDABLE_P(mid, flag, argc, kwarg)) {
RB_DEBUG_COUNTER_INC(ci_packed);
return vm_ci_new_id(mid, flag, argc, kwarg);