archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-24 05:25:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[rubygems/rubygems] Let fetch understand gem:version syntax

Browse source 
Fix version error message

Add tests to fetch error messages

Fix default version since is not necessary

070620ebe4
This commit is contained in:
ximenasandoval 2021-12-29 14:24:04 -07:00 • committed by git
parent ee5e684bc1
commit cea4a81056
2 changed files with 118 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

28
lib/rubygems/commands/fetch_command.rb
View file

@ -18,6 +18,10 @@ class Gem::Commands::FetchCommand < Gem::Command
add_version_option
add_platform_option
add_prerelease_option
add_option '--[no-]suggestions', 'Suggest alternates when gems are not found' do |value, options|
options[:suggest_alternate] = true
end
end
def arguments # :nodoc:
@ -42,15 +46,27 @@ then repackaging it.
"#{program_name} GEMNAME [GEMNAME ...]"
end
def check_version # :nodoc:
if options[:version] and options[:version] != Gem::Requirement.default and
get_all_gem_names.size > 1
alert_error "Can't use --version with multiple gems. You can specify multiple gems with" \
" version requirements using `gem fetch 'my_gem:1.0.0' 'my_other_gem:~>2.0.0'`"
terminate_interaction 1
end
end
def execute
version = options[:version] || Gem::Requirement.default
check_version
version = options[:version]
platform = Gem.platforms.last
gem_names = get_all_gem_names
gem_names = get_all_gem_names_and_versions
gem_names.each do |gem_name|
dep = Gem::Dependency.new gem_name, version
gem_names.each do |gem_name, gem_version|
gem_version ||= version
dep = Gem::Dependency.new gem_name, gem_version
dep.prerelease = options[:prerelease]
suppress_suggestions = options[:suggest_alternate]
specs_and_sources, errors =
Gem::SpecFetcher.fetcher.spec_for_dependency dep
@ -63,12 +79,10 @@ then repackaging it.
spec, source = specs_and_sources.max_by {|s,| s }
if spec.nil?
show_lookup_failure gem_name, version, errors, options[:domain]
show_lookup_failure gem_name, gem_version, errors, suppress_suggestions, options[:domain]
next
end
source.download spec
say "Downloaded #{spec.full_name}"
end
end