archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-15 13:39:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

CI: Pass -O2 for annocheck

Browse source 
Because `optflags` is pasted into the invocation line after `CC`, we were
building with -O1 unintentionally. You can see this in the configuration
summary: 6727044423 (step):9:753

The check actually fails with -O2. To make it pass, upstream suggest
that we use the annocheck GCC plugin. Since it requires building from
source as the debian package for it isn't ready yet, punt on it for now
and use `--skip-gaps`.

Co-authored-by: Jun Aruga <jaruga@redhat.com>
This commit is contained in:
Alan Wu 2023-01-16 15:30:18 -05:00
parent c6b90e5e9c
commit e50f102489
Notes: git 2023-02-03 18:27:06 +00:00
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
.github/workflows/compilers.yml vendored
View file

@ -83,12 +83,13 @@ jobs:
container: gcc-11 container: gcc-11
env: env:
# Minimal flags to pass the check. # Minimal flags to pass the check.
default_cc: 'gcc-11 -O2 -fcf-protection -Wa,--generate-missing-build-notes=yes' default_cc: 'gcc-11 -fcf-protection -Wa,--generate-missing-build-notes=yes'
optflags: '-O2'
LDFLAGS: '-Wl,-z,now' LDFLAGS: '-Wl,-z,now'
# FIXME: Drop skipping options # FIXME: Drop skipping options
# https://bugs.ruby-lang.org/issues/18061 # https://bugs.ruby-lang.org/issues/18061
# https://sourceware.org/annobin/annobin.html/Test-pie.html # https://sourceware.org/annobin/annobin.html/Test-pie.html
TEST_ANNOCHECK_OPTS: "--skip-pie" TEST_ANNOCHECK_OPTS: "--skip-pie --skip-gaps"
check: true check: true
- { name: clang-16, env: { default_cc: clang-16 } } - { name: clang-16, env: { default_cc: clang-16 } }
- { name: clang-15, env: { default_cc: clang-15 } } - { name: clang-15, env: { default_cc: clang-15 } }