archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-15 13:39:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Don't call hash tombstone compaction from GC compaction

Browse source 
Tombstone removal may possibly require allocation, and we're not allowed
to allocate during GC.  This commit also renames `set_compact` to
`set_update_references` to differentiate tombstone removal compaction with GC
object compaction.

Co-Authored-By: Max Bernstein <max.bernstein@shopify.com>
Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
This commit is contained in:
Aaron Patterson 2025-04-29 11:33:42 -07:00 • committed by Aaron Patterson
parent 9cdc46587d
commit e6974be545
Notes: git 2025-04-29 20:33:28 +00:00
2 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
set.c
View file

@ -179,10 +179,9 @@ set_replace_ref(st_data_t *key, st_data_t argp, int existing)
}
static void
set_compact(void *ptr)
set_update_references(void *ptr)
{
struct set_object *sobj = ptr;
set_compact_table(&sobj->table);
set_foreach_with_replace(&sobj->table, set_foreach_replace, set_replace_ref, 0);
}
@ -192,7 +191,7 @@ static const rb_data_type_t set_data_type = {
.dmark = set_mark,
.dfree = set_free,
.dsize = set_size,
.dcompact = set_compact,
.dcompact = set_update_references,
},
.flags = RUBY_TYPED_EMBEDDABLE | RUBY_TYPED_FREE_IMMEDIATELY | RUBY_TYPED_WB_PROTECTED | RUBY_TYPED_FROZEN_SHAREABLE
};