mirror of
https://github.com/ruby/ruby.git
synced 2025-09-15 16:44:01 +02:00
[ruby/set] Speed up Set#flatten
Improved performance by ensuring that identical `Set` objects are
processed only once.
cadb686e93
This commit is contained in:
parent
96fac34797
commit
f2334cf4b1
1 changed files with 7 additions and 4 deletions
11
lib/set.rb
11
lib/set.rb
|
@ -353,16 +353,19 @@ class Set
|
||||||
klass.new(self, *args, &block)
|
klass.new(self, *args, &block)
|
||||||
end
|
end
|
||||||
|
|
||||||
def flatten_merge(set, seen = Set.new) # :nodoc:
|
def flatten_merge(set, seen = {}) # :nodoc:
|
||||||
set.each { |e|
|
set.each { |e|
|
||||||
if e.is_a?(Set)
|
if e.is_a?(Set)
|
||||||
if seen.include?(e_id = e.object_id)
|
case seen[e_id = e.object_id]
|
||||||
|
when true
|
||||||
raise ArgumentError, "tried to flatten recursive Set"
|
raise ArgumentError, "tried to flatten recursive Set"
|
||||||
|
when false
|
||||||
|
next
|
||||||
end
|
end
|
||||||
|
|
||||||
seen.add(e_id)
|
seen[e_id] = true
|
||||||
flatten_merge(e, seen)
|
flatten_merge(e, seen)
|
||||||
seen.delete(e_id)
|
seen[e_id] = false
|
||||||
else
|
else
|
||||||
add(e)
|
add(e)
|
||||||
end
|
end
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue