From f657fd150f46ab4d93344d34bcb663630d7f064a Mon Sep 17 00:00:00 2001 From: eileencodes Date: Tue, 16 Jan 2024 16:11:24 -0500 Subject: [PATCH] [Prism] Implement defined? for PM_CALL_AND_WRITE_NODE Ruby code: ```ruby defined?(PrismTestSubclass.test_call_and_write_node &&= 1) ``` Instructions: ``` "********* Ruby *************" == disasm: #@:1 (1,0)-(59,58)> 0000 putobject "assignment" ( 59)[Li] 0002 leave "********* PRISM *************" == disasm: #@:58 (58,0)-(58,58)> 0000 putobject "assignment" ( 58)[Li] 0002 leave ``` Related: ruby/prism#2188 --- prism_compile.c | 1 + test/ruby/test_compile_prism.rb | 2 ++ 2 files changed, 3 insertions(+) diff --git a/prism_compile.c b/prism_compile.c index 7496105bc1..98b7b3537e 100644 --- a/prism_compile.c +++ b/prism_compile.c @@ -2686,6 +2686,7 @@ pm_compile_defined_expr0(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *co ADD_INSN3(ret, &dummy_line_node, defined, INT2FIX(DEFINED_ZSUPER), 0, PUSH_VAL(DEFINED_ZSUPER)); return; + case PM_CALL_AND_WRITE_NODE: case PM_CONSTANT_WRITE_NODE: case PM_CONSTANT_OPERATOR_WRITE_NODE: case PM_CONSTANT_AND_WRITE_NODE: diff --git a/test/ruby/test_compile_prism.rb b/test/ruby/test_compile_prism.rb index d547f82fe3..38bce4f303 100644 --- a/test/ruby/test_compile_prism.rb +++ b/test/ruby/test_compile_prism.rb @@ -237,6 +237,8 @@ module Prism assert_prism_eval("defined?(defined?(a))") assert_prism_eval('defined?(:"#{1}")') assert_prism_eval("defined?(`echo #{1}`)") + + assert_prism_eval("defined?(PrismTestSubclass.test_call_and_write_node &&= 1)") end def test_GlobalVariableReadNode