From fb1eed3f7034c9219f83d086011296f8955bcddc Mon Sep 17 00:00:00 2001 From: eileencodes Date: Wed, 17 Jan 2024 10:44:01 -0500 Subject: [PATCH] [Prism] Implement defined? for PM_FOR_NODE Ruby code: ```ruby defined?(for i in [1,2] do; i; end) ``` Instructions: ``` "********* Ruby *************" == disasm: #@:1 (1,0)-(59,43)> 0000 putobject "expression" ( 59)[Li] 0002 leave "********* PRISM *************" == disasm: #@:58 (58,0)-(58,43)> 0000 putobject "expression" ( 58)[Li] 0002 leave ``` Related: ruby/prism#2188 --- prism_compile.c | 1 + test/ruby/test_compile_prism.rb | 1 + 2 files changed, 2 insertions(+) diff --git a/prism_compile.c b/prism_compile.c index e8eab6ed35..5fe98a3737 100644 --- a/prism_compile.c +++ b/prism_compile.c @@ -2542,6 +2542,7 @@ pm_compile_defined_expr0(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *co case PM_DEF_NODE: case PM_DEFINED_NODE: case PM_FLOAT_NODE: + case PM_FOR_NODE: case PM_HASH_NODE: case PM_IMAGINARY_NODE: case PM_INTEGER_NODE: diff --git a/test/ruby/test_compile_prism.rb b/test/ruby/test_compile_prism.rb index 98083c4368..5b301b6f26 100644 --- a/test/ruby/test_compile_prism.rb +++ b/test/ruby/test_compile_prism.rb @@ -253,6 +253,7 @@ module Prism assert_prism_eval("defined?(case [1, 2, 3]; in [1, 2, 3]; 4; end)") assert_prism_eval("defined?(class PrismClassA; end)") assert_prism_eval("defined?(def prism_test_def_node; end)") + assert_prism_eval("defined?(for i in [1,2] do; i; end)") end def test_GlobalVariableReadNode