archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-08-15 13:39:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

* util.c (valid_filename): use O_EXCL to get rid of clobbering

Browse source 
existing files in race conditions.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@15586 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
nobu 2008-02-23 18:53:00 +00:00
parent fa222ced64
commit fe80dd73b9
3 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

14
util.c
View file

@ -345,23 +345,19 @@ valid_filename(const char *s)
{
int fd;
/*
// if the file exists, then it's a valid filename!
*/
if (_access(s, 0) == 0) {
return 1;
}
/*
// It doesn't exist, so see if we can open it.
*/
if ((fd = _open(s, O_CREAT, 0666)) >= 0) {
if ((fd = _open(s, O_CREAT|O_EXCL, 0666)) >= 0) {
_close(fd);
_unlink(s); /* don't leave it laying around */
return 1;
}
else if (errno == EEXIST) {
/* if the file exists, then it's a valid filename! */
return 1;
}
return 0;
}
#endif