archive/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2025-09-22 20:14:02 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4
75689 commits 28 branches 1175 tags 525 MiB
Commit graph

16449 commits

Author SHA1 Message Date
Shugo Maeda
2670509ebb [ruby/net-ftp] Add test cases 
865232bb2a
 2021-04-27 21:22:42 +09:00
Shugo Maeda
4ae27d8075
[ruby/net-ftp] Reduce resource cosumption of Net::FTP::TIME_PARSER 
Reported by Alexandr Savca as a DoS vulnerability, but Net::FTP is a
client library and the impact of the issue is low, so I have decided
to fix it as a normal issue.
Based on patch by nobu.

a93af636f8
 2021-04-27 21:21:33 +09:00
Jeremy Evans
990baec411 [ruby/net-ftp] Close the passive connection data socket if there is an error setting up the transfer 
Previously, the connection leaked in this case.  This uses
begin/ensure and checking for an error in the ensure block.

An alternative approach would be to not even perform the
connection until after the RETR (or other) command has been
sent.  However, I'm not sure all FTP servers support that.
The current behavior is:

* Send (PASV/EPSV)
* Connect to the host/port returned in 227/229 reply
* Send (RETR/other command)

Changing it to connect after the RETR could break things.
FTP servers might expect that the client has already
connected before sending the RETR.  The alternative
approach is more likely to introduce backwards compatibility
issues, compared to the begin/ensure approach taken here.

Fixes Ruby Bug 17027

6e8535f076
 2021-04-27 21:21:00 +09:00
Hiroshi SHIBATA
fb819d9331 [ruby/net-ftp] Re-apply 827e471d438fdec1ae329afb5912b8e06d534823 
3ca80368c4
 2021-04-27 21:19:14 +09:00
Hiroshi SHIBATA
ac739f42eb [ruby/matrix] Guard for < Ruby 3.0 
1ef660c627
 2021-04-27 21:07:17 +09:00
Yusuke Endoh
ea88f49a76 test/ruby/test_exception.rb: suppress "warning: statement not reached" 2021-04-27 17:07:44 +09:00
Yusuke Endoh
2c7d3b3a72 node.c (rb_ast_new): imemo_ast is WB-unprotected 
Previously imemo_ast was handled as WB-protected which caused a segfault
of the following code:

    # shareable_constant_value: literal
    M0 = {}
    M1 = {}
    ...
    M100000 = {}

My analysis is here: `shareable_constant_value: literal` creates many
Hash instances during parsing, and add them to node_buffer of imemo_ast.
However, the contents are missed because imemo_ast is incorrectly
WB-protected.

This changeset makes imemo_ast as WB-unprotected.
 2021-04-26 22:46:51 +09:00
Nobuyoshi Nakada
5219b4ddb4 [ruby/irb] Added setup and teardown to TestIRB::TestInit 
Not to be affected by existing rc files in all tests.

bf434892b4
 2021-04-26 21:15:06 +09:00
Nobuyoshi Nakada
8fdc45c894 [ruby/irb] Added colorable keyword option 
Currently `IRB::Color.colorize` and `IRB::Color.colorize_code`
refer `$stdin.tty?` internally.
This patch adds `colorable` keyword option which overrides it.

402e3f1907
 2021-04-26 21:14:52 +09:00
Nobuyoshi Nakada
687ab5dcad [ruby/irb] Assertions on non-tty 
ede12890d2
 2021-04-26 21:14:44 +09:00
Nobuyoshi Nakada
75f1ad8cb3 [ruby/irb] Added test_colorize 
10e290fc3a
 2021-04-26 21:14:37 +09:00
Nobuyoshi Nakada
6ddaad606e [ruby/irb] Added assert_equal_with_term 
b690da96d8
 2021-04-26 21:14:31 +09:00
Kazuhiro NISHIYAMA
2b487d36f0
Remove test of removed reverse VM instruction 
since 5512353d97
 2021-04-26 11:07:53 +09:00
Ryuta Kamizono
33f2ff3bab Fix some typos by spell checker 2021-04-26 10:07:41 +09:00
Alan Wu
dee58d7ae7
Add back checks for empty kw splat with tests (#4405) 
This reverts commit a224ce8150.
Turns out the checks are needed to handle splatting an array with an
empty ruby2 keywords hash.
 2021-04-23 22:17:20 -04:00
Jeremy Evans
4b36a597f4 Fix setting method visibility for a refinement without an origin class 
If a class has been refined but does not have an origin class,
there is a single method entry marked with VM_METHOD_TYPE_REFINED,
but it contains the original method entry.  If the original method
entry is present, we shouldn't skip the method when searching even
when skipping refined methods.

Fixes [Bug #17519]
 2021-04-23 16:31:18 -07:00
Yusuke Endoh
71ee05c936 test/ruby/test_assignment.rb: Avoid "assigned but unused variable" 2021-04-23 22:11:01 +09:00
Hiroshi SHIBATA
3ea2a40713
Suppress warnings for unsued variable 2021-04-23 10:35:29 +09:00
Jeremy Evans
3e27ca6047 [ruby/uri] Add tests for URI::RFC{2396,3986}_Parser#inspect 
d47dae2f8e
 2021-04-22 14:54:37 +09:00
Lukas Zapletal
c46a4b8c7f [ruby/uri] Optimize URI#hostname and URI#hostname= 
3b7ccfd835
 2021-04-22 14:54:28 +09:00
Hiroshi SHIBATA
674760316c
Merge net-imap-0.2.0 2021-04-22 14:37:45 +09:00
Hiroshi SHIBATA
01f131457f
Separate test used by test_ractor for Ractor in test_time.rb 2021-04-22 13:35:30 +09:00
Keith Bennett
4f39a35b60
[ruby/benchmark] Add comment about terminating newline in captions; fix test method name. 
02ce298d3e
 2021-04-22 11:51:37 +09:00
Jeremy Evans
f818b1ed2b
[ruby/cgi] Add test for escapeHTML/unescapeHTML invalid encoding fix in pure ruby version 
Also, remove pointless assert_nothing_raised(ArgumentError) while
here.

c05edf5608
 2021-04-22 11:51:36 +09:00
Kir Shatrov
53d153e42c
[ruby/time] Make Time friendly to Ractor 
c784e4f166
 2021-04-22 11:51:36 +09:00
Koichi Sasada
609de71f04 fix raise in exception with jump 
add_ensure_iseq() adds ensure block to the end of
jump such as next/redo/return. However, if the rescue
cause are in the body, this rescue catches the exception
in ensure clause.

  iter do
    next
  rescue
    R
  ensure
    raise
  end

In this case, R should not be executed, but executed without this patch.

Fixes [Bug #13930]
Fixes [Bug #16618]

A part of tests are written by @jeremyevans https://github.com/ruby/ruby/pull/4291
 2021-04-22 11:33:39 +09:00
Jeremy Evans
50c54d40a8
Evaluate multiple assignment left hand side before right hand side 
In regular assignment, Ruby evaluates the left hand side before
the right hand side.  For example:

```ruby
foo[0] = bar
```

Calls `foo`, then `bar`, then `[]=` on the result of `foo`.

Previously, multiple assignment didn't work this way.  If you did:

```ruby
abc.def, foo[0] = bar, baz
```

Ruby would previously call `bar`, then `baz`, then `abc`, then
`def=` on the result of `abc`, then `foo`, then `[]=` on the
result of `foo`.

This change makes multiple assignment similar to single assignment,
changing the evaluation order of the above multiple assignment code
to calling `abc`, then `foo`, then `bar`, then `baz`, then `def=` on
the result of `abc`, then `[]=` on the result of `foo`.

Implementing this is challenging with the stack-based virtual machine.
We need to keep track of all of the left hand side attribute setter
receivers and setter arguments, and then keep track of the stack level
while handling the assignment processing, so we can issue the
appropriate topn instructions to get the receiver.  Here's an example
of how the multiple assignment is executed, showing the stack and
instructions:

```
self                                      # putself
abc                                       # send
abc, self                                 # putself
abc, foo                                  # send
abc, foo, 0                               # putobject 0
abc, foo, 0, [bar, baz]                   # evaluate RHS
abc, foo, 0, [bar, baz], baz, bar         # expandarray
abc, foo, 0, [bar, baz], baz, bar, abc    # topn 5
abc, foo, 0, [bar, baz], baz, abc, bar    # swap
abc, foo, 0, [bar, baz], baz, def=        # send
abc, foo, 0, [bar, baz], baz              # pop
abc, foo, 0, [bar, baz], baz, foo         # topn 3
abc, foo, 0, [bar, baz], baz, foo, 0      # topn 3
abc, foo, 0, [bar, baz], baz, foo, 0, baz # topn 2
abc, foo, 0, [bar, baz], baz, []=         # send
abc, foo, 0, [bar, baz], baz              # pop
abc, foo, 0, [bar, baz]                   # pop
[bar, baz], foo, 0, [bar, baz]            # setn 3
[bar, baz], foo, 0                        # pop
[bar, baz], foo                           # pop
[bar, baz]                                # pop
```

As multiple assignment must deal with splats, post args, and any level
of nesting, it gets quite a bit more complex than this in non-trivial
cases. To handle this, struct masgn_state is added to keep
track of the overall state of the mass assignment, which stores a linked
list of struct masgn_attrasgn, one for each assigned attribute.

This adds a new optimization that replaces a topn 1/pop instruction
combination with a single swap instruction for multiple assignment
to non-aref attributes.

This new approach isn't compatible with one of the optimizations
previously used, in the case where the multiple assignment return value
was not needed, there was no lhs splat, and one of the left hand side
used an attribute setter.  This removes that optimization. Removing
the optimization allowed for removing the POP_ELEMENT and adjust_stack
functions.

This adds a benchmark to measure how much slower multiple
assignment is with the correct evaluation order.

This benchmark shows:

* 4-9% decrease for attribute sets
* 14-23% decrease for array member sets
* Basically same speed for local variable sets

Importantly, it shows no significant difference between the popped
(where return value of the multiple assignment is not needed) and
!popped (where return value of the multiple assignment is needed)
cases for attribute and array member sets.  This indicates the
previous optimization, which was dropped in the evaluation
order fix and only affected the popped case, is not important to
performance.

Fixes [Bug #4443]
 2021-04-21 10:49:19 -07:00
Yusuke Endoh
fb04c69418
array.c (rb_ary_zip): take only as many as needed from an Enumerator (#4389) 
[Bug #17814]
 2021-04-21 13:02:29 +09:00
Travis Hunter
55d91a096a Add Array#intersect? 2021-04-16 16:06:36 +09:00
Hiroshi SHIBATA
96741765d8 Merge the master branch of RubyGems 2021-04-15 15:36:15 +09:00
Yusuke Endoh
582f4bc188 test/ruby/test_gc_compact.rb: Use assert_separately for debugging 
... the following timeout failure.

20210408T213303Z.fail.html.gz
```
[ 8871/21204] TestGCCompact#test_ast_compactstimeout: output interval exceeds 600.0 seconds.
timeout: the process group 28416 is alive.
PSOUT  PGID   PID     ELAPSED %CPU    VSZ COMMAND         COMMAND
PSOUT 28416 28416       12:46  0.0 108120 gmake           gmake TESTS=--hide-skip -v RUBYOPT=-w test-all
PSOUT 28416 28423       12:46 88.2 1446124 ruby           ./test/runner.rb: TestGCCompact#test_ast_compacts
timeout: INT signal sent.
timeout: INT signal sent.
timeout: TERM signal sent.
timeout: TERM signal sent.
timeout: KILL signal sent.
```

This error repeatedly occurs on RHEL s390x.

This change sends SEGV when timeout occurs so that it should dump the backtrace.
 2021-04-09 13:59:46 +09:00
aycabta
5543695a19
[ruby/reline] Separate keystrokes each editing mode 
ee23e6f3f8
 2021-04-08 21:41:00 +09:00
Yusuke Endoh
ee372aa873 test/zlib/test_zlib.rb: Set binmode to test output file 
Seems like the test `TestZlibGzipFile#test_gzip_reader_zcat` fails when
the timestamp has `\n\n`.

38597932
```
  1) Error:
TestZlibGzipFile#test_gzip_reader_zcat:
Zlib::DataError: invalid distance too far back
    C:/projects/ruby/test/zlib/test_zlib.rb:522:in `initialize'
    C:/projects/ruby/test/zlib/test_zlib.rb:522:in `new'
    C:/projects/ruby/test/zlib/test_zlib.rb:522:in `zcat'
    C:/projects/ruby/test/zlib/test_zlib.rb:522:in `block (2 levels) in test_gzip_reader_zcat'
    C:/projects/ruby/test/zlib/test_zlib.rb:521:in `open'
    C:/projects/ruby/test/zlib/test_zlib.rb:521:in `block in test_gzip_reader_zcat'
    C:/projects/ruby/lib/tempfile.rb:358:in `create'
    C:/projects/ruby/test/zlib/test_zlib.rb:510:in `test_gzip_reader_zcat'
```

The test time is around 2021-04-08 04:40 +0900. Maybe the following time
should trigger the bug.

```
irb(main):001:0> Time.at(1617824266)
=> 2021-04-08 04:37:46 +0900
irb(main):002:0> [1617824266].pack("V")
=> "\n\nn`"
```
 2021-04-08 14:26:42 +09:00
Peter Zhu
d8a13e5049 [Bug #17780] Fix Method#super_method for module alias 
Method#super_method crashes for aliased module methods because they are
not defined on a class. This bug was introduced in
c60aaed185 as part of bug #17130.
 2021-04-07 15:16:58 -04:00
Yusuke Endoh
fbbc37dc1d test/drb/test_drb.rb: Specify the host of DRbServer 
to try fixing the following error.

20210407T063004Z.log.html.gz
```
[  605/21105] DRbTests::TestDRbSSLAry#test_06_next/home/chkbuild/chkbuild/tmp/build/20210407T063004Z/ruby/lib/drb/drb.rb:1138:in `method_missing': undefined method `regist' for [1, 2, "III", 4, "five", 6]:Array (NoMethodError)
	from /home/chkbuild/chkbuild/tmp/build/20210407T063004Z/ruby/lib/drb/extserv.rb:21:in `block in initialize'
	from /home/chkbuild/chkbuild/tmp/build/20210407T063004Z/ruby/.ext/common/monitor.rb:202:in `synchronize'
	from /home/chkbuild/chkbuild/tmp/build/20210407T063004Z/ruby/.ext/common/monitor.rb:202:in `mon_synchronize'
	from /home/chkbuild/chkbuild/tmp/build/20210407T063004Z/ruby/lib/drb/extserv.rb:20:in `initialize'
	from /home/chkbuild/chkbuild/tmp/build/20210407T063004Z/ruby/test/drb/ut_array_drbssl.rb:35:in `new'
	from /home/chkbuild/chkbuild/tmp/build/20210407T063004Z/ruby/test/drb/ut_array_drbssl.rb:35:in `<main>'
 = 100.05 s
```

Here is my analysis:
The test of drb used both `druby://:0` and `druby://localhost:0` for
DRbServer. However, the former listens on IPv4, and the latter does on
IPv6, depending on environments. The port 0 is automatically assigned,
but sometimes the same port is used to both because they are different
protocols (IPv4 and IPv6). In this case, their URIs are resolved to the
completely same one (`druby://localhost:port`), which confuses the
method `DRb.here?` which determines the DRbObject is remote or local.

This changeset uses `druby://localhost:0` consistently.
 2021-04-07 16:34:19 +09:00
Kazuhiro NISHIYAMA
31ba817887
Try to fix Leaked file descriptor 
2274767991 (step):15:118
```
Leaked file descriptor: DRbTests::TestDRbTCP#test_immediate_close: 7 : #<TCPServer:fd 7, AF_INET, 0.0.0.0, 42451>
Leaked file descriptor: DRbTests::TestDRbTCP#test_immediate_close: 9 : #<IO:fd 9>
Leaked file descriptor: DRbTests::TestDRbTCP#test_immediate_close: 10 : #<IO:fd 10>
```
 2021-04-06 16:03:20 +09:00
Nobuyoshi Nakada
856a9701fd
Get rid of multibyte prefix to tmpdir 2021-04-05 21:20:51 +09:00
Nobuyoshi Nakada
4b6fa03a72
[ruby/tmpdir] Make usable chars more strict 
Remove other than alphanumeric and some punctuations considered
filesystem-safe, instead of removing some unsafe chars only.

https://hackerone.com/reports/1131465

adf294bc2d
 2021-04-05 21:08:57 +09:00
Nobuyoshi Nakada
4b92633043 [ruby/irb] Suppress verbose messages in the parallel test 
`:VERBOSE` flag needs to be set prior to `IRB::Irb.new`.

0dbe292979
 2021-04-05 14:00:21 +09:00
Yusuke Endoh
2fcae4f90a test/ruby/test_lambda.rb: Remove "warning: assigned but unused variable" 2021-04-04 15:26:09 +09:00
Nobuyoshi Nakada
64b991b0cd [ruby/rdoc] Links to document texts without "rdoc-ref:" prefix 
While links to generated HTML from RDoc file needs to be prefixed
by "rdoc-ref:" currently, in case of explicit references this
seems just redundant.

Also GitHub RDoc support does not work with this prefix.

This patch lets links to such document texts (".rb", ".rdoc" and
".md" now) refer URLs generated by `RDoc::TopLevel#http_url`
without the prefix.

f18b27b69d
 2021-04-03 01:22:09 +09:00
Nobuyoshi Nakada
a6948329f8 [ruby/rdoc] Clarify that dots in URL are replaced 
The dots in all path components from the document root are
replaced with underscores, not only in the basename.

7a3417ea4c
 2021-04-03 01:22:00 +09:00
aycabta
61e1cf23ac [ruby/rdoc] Treat emphasis tags as excluding other notations 
And exclusive notations don't exclude other exclusive notations.

b8baa9a435
 2021-04-03 01:21:50 +09:00
aycabta
e84d275fe6 [ruby/rdoc] Treat other tags as word boundaries 
8222f85a17
 2021-04-03 01:21:38 +09:00
aycabta
54aa11efa8 [ruby/rdoc] Disable other notations in <code> tags 
0cd3b55210
 2021-04-03 01:21:12 +09:00
aycabta
ab89c45b90 [ruby/irb] Evaluate each toplevel statement 
bc1b1d8bc3
 2021-04-03 01:17:08 +09:00
aycabta
254cd937c2 [ruby/irb] Add test for multiline paste 
e93c9cb54d
 2021-04-03 01:15:46 +09:00
aycabta
0eb1491957 [ruby/irb] Add yamatanooroti test example 
279155fcee
 2021-04-03 01:14:31 +09:00
aycabta
7e93917458 [ruby/reline] Reset @rest_height when clear screen 
3a7019b0d5
 2021-04-02 17:33:48 +09:00
Takashi Kokubun
9e336f73fb [ruby/irb] Add show_source command 
108cb04352
 2021-04-02 16:40:06 +09:00