Commit graph

66 commits

Author SHA1 Message Date
Utkarsh Gupta
22ee047f73 [rubygems/rubygems] Only add .rubocop.yml when --rubocop flag is passed
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

ef2dae4222
2020-06-18 19:14:15 +09:00
Utkarsh Gupta
ec98d56153 Ship default .rubocop.yml
Currently, there is no `.rubocop.yml` shipped by default.
So when a user runs `rubocop` after creating a new gem via
`bundle gem foo`, it throws a bunch of offenses.

With the default `.rubocop.yml` present, the number of those
offenses significantly reduce by 25.

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
2020-06-18 19:14:15 +09:00
Utkarsh Gupta
d9c888d394 [rubygems/rubygems] Only add .rubocop.yml when --rubocop flag is passed
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

ef2dae4222
2020-06-18 19:14:15 +09:00
David Rodríguez
f9de8ccf1e Rename hidden templates
Because they don't play nice with ruby-core's gitignore and cause issues
with ruby-core integration.

Also, because it's consistent with other templates such as `gitignore.tt`.
2020-06-18 19:14:15 +09:00
Frank Lam
1cb88eb2ba Use consistent filenaming for Travis template 2020-06-18 19:14:15 +09:00
Frank Lam
f6c8ca0359 [rubygems/rubygems] Move already configured --test hint to before test file creation
9e5f7a9099
2020-06-18 19:14:15 +09:00
Frank Lam
0ba2f3e8a9 [rubygems/rubygems] Move already configured --ci hint to before CI file creation
2af2abe5fd
2020-06-18 19:14:15 +09:00
Frank Lam
091daaa715 [rubygems/rubygems] Lower verboseness of user-facing text for bundle gem
288f073c3c
2020-06-18 19:14:15 +09:00
Frank Lam
8e3136a03b [rubygems/rubygems] Make test framework/CI configuration for bundle gem consistent
* Add hints for --ci option

5f779f45b0
2020-06-18 19:14:15 +09:00
Frank Lam
52a900773e [rubygems/rubygems] Incorporate naming/grammar suggestions from olleolleolle
80571452ca
2020-06-18 19:14:15 +09:00
Andre Arko
3a2016b994 [rubygems/rubygems] minor language tweaks, small code refactor
84e9f3711c
2020-06-18 19:14:15 +09:00
Colby Swandale
6f9faa66fa [rubygems/rubygems] update question text
f14c8a5ec2
2020-06-18 19:14:15 +09:00
Hiroshi SHIBATA
cc059b16b2 Manually cherry-picked at 80260b3496 2020-06-18 19:14:15 +09:00
Jakob Krigovsky
f9872c50cc Update links from rubygems/bundler to rubygems/rubygems 2020-06-05 07:32:42 +09:00
DEVRAJ KUMAR
9139acca66 [rubygems/rubygems] Fix bundle info not indicating a gem which has been deleted, unlike bundle show
Co-Authored-By: David Rodríguez <deivid.rodriguez@riseup.net>

2851b40ffb
2020-06-05 07:32:42 +09:00
Frank Lam
f0ae5ac313 [rubygems/rubygems] Display test_framework_hint before prompting for user selection
* On ubuntu-bundler/ubuntu_bundler3, longer lines of text get cut off
after ~50 characters
* Example: https://github.com/rubygems/rubygems/pull/3544/checks?check_run_id=703658810

6a17847fd8
2020-06-05 07:32:42 +09:00
Frank Lam
154c2717da [rubygems/rubygems] Add user hint specs for bundle gem --test
1d2292a88f
2020-06-05 07:32:42 +09:00
Frank Lam
58267fa59e [rubygems/rubygems] Conditionally display test framework help text
8b51a86265
2020-06-05 07:32:42 +09:00
Frank Lam
f75bd9bb8b [rubygems/rubygems] Fix bundle gem ignoring global gem.test config
* bundle gem previously ignored gem.test when passed empty -t flag,
defaulting to RSpec
* bundle gem will now ask user for test framework when passed empty -t
flag and gem.test is set to false, but will not overwrite gem.test
* thor option parsing for String types falls back to human name for nil,
so setting lazy_default to nil won't work
* c5161501e0/lib/thor/parser/options.rb (L224)

Default to Bundler.settings["gem.test"] for empty --test

Add shared examples for test framework to newgem spec

Add examples for empty --test flag to newgem spec

Simplify conditional for prompting test framework

Follow naming conventions for bundler settings

Add more descriptive test framework help text for bundle gem

Update man pages for bundler

ab0785a09f
2020-06-05 07:32:42 +09:00
David Rodríguez
b2a460ea3e [rubygems/rubygems] Centralize with and without setting
5e854722e2
2020-06-05 07:32:42 +09:00
David Rodríguez
9422162f71 [rubygems/rubygems] Remove redundant substraction
365b46329b
2020-06-05 07:32:42 +09:00
David Rodríguez
97d05c9db3 [rubygems/rubygems] Remove unnecessary option mutation
744c03d144
2020-06-05 07:32:42 +09:00
David Rodríguez
332ecb0ad1 [rubygems/rubygems] Fix bundle install unintentionally saving configuration
Even if no explicit flags were passed to it.

0598cbb68c
2020-06-05 07:32:42 +09:00
David Rodríguez
6b7a0c0ca7 [rubygems/rubygems] Move all without and with option handling together
5e47879330
2020-06-05 07:32:42 +09:00
David Rodríguez
97267227bb [rubygems/rubygems] Don't recommend the --no-deployment flag
b368c7e0c4
2020-06-05 07:32:42 +09:00
David Rodríguez
f8647343ed Remove a bunch of files that were deleted upstream 2020-05-23 07:28:57 +09:00
Hiroshi SHIBATA
0e60b59d58 Update the bundler version with master branch 2020-05-13 07:54:37 +09:00
Nobuyoshi Nakada
2b7409a2f2
Specify explicit separator not to be affected by $; 2020-03-08 17:38:37 +09:00
Hiroshi SHIBATA
13f4f07f21 Merge bundler-2.1.4 2020-01-08 18:00:32 +09:00
Hiroshi SHIBATA
efbc0d499c
Merge bundler-2.1.1 from bundler/bundler 2019-12-18 14:53:19 +09:00
Hiroshi SHIBATA
38002a8adb Prepare to release bundler-2.1.0 2019-12-15 16:41:10 +09:00
Hiroshi SHIBATA
7585bc3187 Merge Bundler 2.1.0.pre.3
Features:
    - Add caller information to some deprecation messages to make them easier to fix [#7361](https://github.com/bundler/bundler/pull/7361)
    - Reconcile `bundle cache` vs `bundle package` everywhere. Now in docs, CLI help and everywhere else `bundle cache` is the preferred version and `bundle package` remains as an alias [#7389](https://github.com/bundler/bundler/pull/7389)
    - Display some basic `bundler` documentation together with ruby's RDoc based documentation [#7394](https://github.com/bundler/bundler/pull/7394)

  Bugfixes:
    - Fix typos deprecation message and upgrading docs [#7374](https://github.com/bundler/bundler/pull/7374)
    - Deprecation warnings about `taint` usage on ruby 2.7 [#7385](https://github.com/bundler/bundler/pull/7385)
    - Fix `--help` flag not correctly delegating to `man` when used with command aliases [#7388](https://github.com/bundler/bundler/pull/7388)
    - `bundle add` should cache newly added gems if an application cache exists [#7393](https://github.com/bundler/bundler/pull/7393)
    - Stop using an insecure folder as a "fallback home" when user home is not defined [#7416](https://github.com/bundler/bundler/pull/7416)
    - Fix `bundler/inline` warning about `Bundler.root` redefinition [#7417](https://github.com/bundler/bundler/pull/7417)
2019-11-11 18:56:25 +09:00
David Rodríguez
0c6529bac2
[bundler/bundler] Revert "Add all platforms to lockfile by default"
This reverts commit 3dc509e645abb497e4dc92a7c42be471ff87db0b.

b5766564fb
2019-09-18 18:26:32 +09:00
Takayuki Nakata
c27aaf1a8f
[bundler/bundler] Fix comments and messages to refer to https url
a86b49f1b9
2019-09-18 18:26:32 +09:00
David Rodríguez
5ea08883cf
[bundler/bundler] Remove old rubies stuff no longer needed
36fb3287f4
2019-08-21 07:58:46 +09:00
David Rodríguez
7659f00a8d [bundler/bundler] Move local variable to only branch where it's used
3995b3345d
2019-08-18 13:44:36 +09:00
Zehan Zhao
d80f5399ad [bundler/bundler] Fix open default gem error
792d724752
2019-08-18 13:44:26 +09:00
David Rodríguez
cc644c7116 [bundler/bundler] Fix bundle doctor command
Previously `bundle doctor` would fail on any bundle that does not
include git gems or plugins. This is because the previously used
`Bundler.home` does not exist unless the bundle includes git gems or
plugins. For example, with `bundle config set path .bundle`, it points
to which does not exist unless this kind of gems exist in the Gemfile.

The name `Bundler.home` is really unfortunate, it should probably be
have more descriptive name, and be private. But for now I just want to
make `bundle doctor` usable.

5531a18c1e
2019-08-18 13:44:03 +09:00
David Rodríguez
b587e8c7f1 [bundler/bundler] Add --[no-]git option to bundle gem
I think using `--no-git` can be useful when creating gems inside
monorepos.

154c687310
2019-08-16 14:30:23 +09:00
David Rodríguez
267a72be80
[bundler/bundler] Enable Style/UnneededInterpolation cop
4c6a3c3cf7
2019-08-03 09:30:00 +09:00
David Rodríguez
b855e33b65
[bundler/bundler] Add exclamation mark to method
To indicate that it can raise.

Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com>
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>

584e841624
2019-08-03 09:29:59 +09:00
David Rodríguez
1fbd6a1fe0
[bundler/bundler] Move strict to an attribute
Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com>
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>

7b68d86bdd
2019-08-03 09:29:59 +09:00
David Rodríguez
1069139a33
[bundler/bundler] Extract some methods
Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com>
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>

027aba0cff
2019-08-03 09:29:59 +09:00
David Rodríguez
ee7ec87007
[bundler/bundler] Unfold message to single line for readability
d845a213ca
2019-08-03 09:29:59 +09:00
Guillermo Guerrero
e1ccaa8782
[bundler/bundler] Extract a print_gems method
0d8c8d207e
2019-08-03 09:29:59 +09:00
Guillermo Guerrero
759930dd11
[bundler/bundler] Less complexity
be9d6e7cfc
2019-08-03 09:29:59 +09:00
David Rodríguez
fd3411c73f
[bundler/bundler] Move more locals to attributes
Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com>
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>

4335df3e4c
2019-08-03 09:29:59 +09:00
David Rodríguez
a42478502c
[bundler/bundler] Move any? logic to the attribute
It's the only usage of the `options_include_groups` attribute and its
name suggests a boolean, so it fits better now.

Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com>
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>

53c0fae760
2019-08-03 09:29:59 +09:00
David Rodríguez
4e76aef280
[bundler/bundler] Move options_include_groups to an attribute
Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com>
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>

832fb900f0
2019-08-03 09:29:59 +09:00
David Rodríguez
30d10be036
[bundler/bundler] Prefer feature flag to harcoded check
8c83921d08
2019-08-03 09:29:59 +09:00