Commit graph

12164 commits

Author SHA1 Message Date
Hiroshi SHIBATA
3fe5909ef1 [rubygems/rubygems] util/rubocop -A --only Style/SelfAssignment
7c1168c623
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
f86296fa0a [rubygems/rubygems] util/rubocop -A --only Style/EmptyElse
04227104ac
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
4ab23df2c4 [rubygems/rubygems] util/rubocop -A --only Style/RedundantParentheses
295691d4dc
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
d8c5fa963f [rubygems/rubygems] util/rubocop -A --only Style/YodaCondition
3594945391
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
66bd2c1a1c [rubygems/rubygems] util/rubocop -A --only Style/CommentAnnotation
4e77a1d1d5
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
52ea7afa5f [rubygems/rubygems] util/rubocop -A --only Style/NegatedIf
aa95ee27a2
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
bd57322bfe [rubygems/rubygems] util/rubocop -A --only Style/DefWithParentheses
91391ceedf
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
03b82d1865 [rubygems/rubygems] util/rubocop -A --only Style/SingleLineMethods
fa2e835ed2
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
d2cebb4e31 [rubygems/rubygems] util/rubocop -A --only Style/NumericLiterals
860669b08a
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
712d6e675b [rubygems/rubygems] util/rubocop -A --only Style/RedundantInterpolation
add44e56eb
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
0b632b9cdd [rubygems/rubygems] util/rubocop -A --only Style/ClassCheck
1c3356a872
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
567db6064b [rubygems/rubygems] util/rubocop -A --only Style/NestedParenthesizedCalls
a875fdb535
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
3d4c3f9e4f [rubygems/rubygems] util/rubocop -A --only Style/ParallelAssignment
5c88c77873
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
4bb5ce8188 [rubygems/rubygems] util/rubocop -A --only Style/StringLiteralsInInterpolation
cb554f6eb7
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
83f9aa8f02 [rubygems/rubygems] util/rubocop -A --only Style/Alias
fba6e94de9
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
f4d1f660d0 [rubygems/rubygems] util/rubocop -A --only Layout/SpaceInsideRangeLiteral
426dd97a31
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
ae81ff0c9b [rubygems/rubygems] util/rubocop -A --only Layout/MultilineBlockLayout
9aa6101942
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
9a1269eaaa [rubygems/rubygems] util/rubocop -A --only Layout/MultilineArrayBraceLayout
f4f45ab27e
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
26d6604343 [rubygems/rubygems] util/rubocop -A --only Layout/MultilineMethodCallBraceLayout
acb0548bf6
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
ce21ce6f23 [rubygems/rubygems] util/rubocop -A --only Layout/FirstArgumentIndentation
0542726fd3
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
4b285e5c6f [rubygems/rubygems] util/rubocop -A --only Layout/AssignmentIndentation
8e64298989
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
9ffd73523d [rubygems/rubygems] util/rubocop -A --only Layout/EmptyLinesAroundExceptionHandlingKeywords
ad1fe68d97
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
583fbc627c [rubygems/rubygems] util/rubocop -A --only Layout/EmptyLinesAroundModuleBody
48c88466b7
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
c480a0c46a [rubygems/rubygems] util/rubocop -A --only Layout/LeadingCommentSpace
4d680320e3
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
dab1d0ed20 [rubygems/rubygems] util/rubocop -A --only Layout/EmptyLineBetweenDefs
00117e69cc
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
ab2278eb34 [rubygems/rubygems] util/rubocop -A --only Lint/UselessAccessModifier
5070f90987
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
eb80f51c6d [rubygems/rubygems] util/rubocop -A --only Lint/RedundantStringCoercion
58e4885493
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
05208c3875 [rubygems/rubygems] util/rubocop -A --only Lint/UnusedBlockArgument
d8efd919db
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
7ab4ede4f5 [rubygems/rubygems] util/rubocop -A --only Performance/TimesMap
976a351f8b
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
139f0927f5 [rubygems/rubygems] util/rubocop -A --only Performance/DoubleStartEndWith
893da27e7c
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
2eb99350f4 [rubygems/rubygems] Removed rubocop:disable detected by Lint/RedundantCopDisableDirective
07b0da6c24
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
fe1b0661cb [rubygems/rubygems] Removed RUBY_PATCHLEVEL and modify condition for ruby_version
b420e287a3
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
b09973a995 [rubygems/rubygems] Also removed condition of RUBY_PATCHLEVEL
16f381be4b
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
8e40d1e153 [rubygems/rubygems] RUBY_PATCHLEVEL was provided after Ruby 1.8.5
7750d5c460
2023-03-17 18:50:55 +09:00
David Rodríguez
a47c54131d [rubygems/rubygems] Remove ensure part in require
I've seen this error sometimes but never found it helpful, since the
culprit has never been thread/monitor related, so it just adds noise.

Right now I'm seeing an issue in CI where we seem to be crashing during
ensure and showing a weird backtrace:

```
#<Thread:0x000055821d7a73b8 /home/runner/work/rubygems/rubygems/lib/rubygems/request_set.rb:167 run> terminated with exception (report_on_exception is true):
/home/runner/work/rubygems/rubygems/lib/rubygems/platform.rb:141:in `==': undefined local variable or method `to_a' for false:FalseClass (NameError)
Did you mean?  to_s
	from /home/runner/work/rubygems/rubygems/lib/rubygems/core_ext/kernel_require.rb:168:in `!='
	from /home/runner/work/rubygems/rubygems/lib/rubygems/core_ext/kernel_require.rb:168:in `require'
	from /home/runner/work/rubygems/rubygems/lib/rubygems.rb:441:in `block in ensure_subdirectories'
	from /home/runner/work/rubygems/rubygems/lib/rubygems.rb:437:in `each'
	from /home/runner/work/rubygems/rubygems/lib/rubygems.rb:437:in `ensure_subdirectories'
	from /home/runner/work/rubygems/rubygems/lib/rubygems.rb:413:in `ensure_gem_subdirectories'
	from /home/runner/work/rubygems/rubygems/lib/rubygems/resolver/specification.rb:110:in `download'
	from /home/runner/work/rubygems/rubygems/lib/rubygems/request_set.rb:173:in `block (2 levels) in install'
```

Let's get this out of the picture in case that helps clarify the
culprit.

87ce40b70e
2023-03-17 18:50:55 +09:00
David Rodríguez
dd0f0a5e6e [rubygems/rubygems] Fix gem uninstall with --install-dir
ac23687353
2023-03-17 18:50:55 +09:00
David Rodríguez
8371c0eac4 [rubygems/rubygems] Fix incorrect error message when multiple platforms are locked
24d2bf9cb2
2023-03-17 18:50:55 +09:00
Mau Magnaguagno
364364c3bd [rubygems/rubygems] Improve TarHeader#calculate_checksum
String#unpack("C*") is equivalent to String#bytes and Array#inject {|a,b| a + b } is equivalent to Array#sum.
This is a minor enhancement in terms of speed and readability.
2023-03-16 12:55:01 +00:00
Hiroshi SHIBATA
f3b129241c [rubygems/rubygems] Applied Layout/SpaceAroundOperators cop
3139587be9
2023-03-16 01:59:12 +00:00
Hiroshi SHIBATA
760b8b7d24 [rubygems/rubygems] Change enforce style with Layout/CaseIndentation on rubygems
d4938259c4
2023-03-16 01:59:11 +00:00
Hiroshi SHIBATA
b528ecc164 [rubygems/rubygems] OpenSSL::Digest is always provided after Ruby 2.4
4f2f2ad412
2023-03-15 11:21:21 +00:00
Hiroshi SHIBATA
04a2550928 [rubygems/rubygems] Don't use full_required_path and extension_dir under the bundler
72169288ff
2023-03-15 03:35:55 +00:00
Hiroshi SHIBATA
31137dc67f [rubygems/rubygems] Removed test for
https://github.com/rubygems/rubygems/pull/6444, I have no idea to
migrate this test to bundler example
yet

0d869019bf
2023-03-15 03:35:54 +00:00
Hiroshi SHIBATA
55a0fbfaf8 [rubygems/rubygems] Move build artifact detection logic for root gemspec to bundler from Gem::Specification.
Gem::Specification#missing_extension? is heavily called from RubyGems.
  We should reduce extra method call from this place.

e24e59d44d
2023-03-15 03:35:54 +00:00
Takashi Kokubun
d8344559b2 RJIT: Simplify how Capstone is used in tests 2023-03-13 20:42:19 -07:00
Yusuke Endoh
56dbf83a85 Prevent a warning: assigned but unused variable
... which made a test fail

20230313T213003Z.fail.html.gz

```
  1) Failure:
TestRubyOptions#test_enable [/home/chkbuild/chkbuild/tmp/build/20230313T213003Z/ruby/test/ruby/test_rubyoptions.rb:176]:
pid 1208 exit 0
| /home/chkbuild/chkbuild/tmp/build/20230313T213003Z/ruby/lib/ruby_vm/rjit/insn_compiler.rb:1257: warning: assigned but unused variable - argc
| /home/chkbuild/chkbuild/tmp/build/20230313T213003Z/ruby/lib/ruby_vm/rjit/insn_compiler.rb:1258: warning: assigned but unused variable - flags
.

1. [2/2] Assertion for "stderr"
   | <[]> expected but was
   | <["/home/chkbuild/chkbuild/tmp/build/20230313T213003Z/ruby/lib/ruby_vm/rjit/insn_compiler.rb:1257: warning: assigned but unused variable - argc",
   |  "/home/chkbuild/chkbuild/tmp/build/20230313T213003Z/ruby/lib/ruby_vm/rjit/insn_compiler.rb:1258: warning: assigned but unused variable - flags"]>.
```
2023-03-13 22:07:25 +09:00
Stan Lo
309ff928f5 [ruby/irb] Replace METHOD_IS_A with ===
(https://github.com/ruby/irb/pull/542)

edd6c30e16
2023-03-13 18:11:58 +00:00
Stan Lo
1095baed34 [ruby/irb] Support inspecting BasicObject
(https://github.com/ruby/irb/pull/541)

1dc2a406a3
2023-03-13 14:31:37 +00:00
Hiroshi SHIBATA
8c6b349805 [rubygems/rubygems] Removed Gem.datadir.
https://github.com/rubygems/rubygems/pull/2216 is imcomplete to remove this method.

34ef915d12
2023-03-13 09:54:04 +00:00
Takashi Kokubun
ed269c81aa RJIT: Count invokeblock exit types 2023-03-12 23:38:11 -07:00