Commit graph

371 commits

Author SHA1 Message Date
David Rodríguez
c74d306b22 [rubygems/rubygems] Only need to call helper once
6ddbf5bcab
2020-05-08 14:13:29 +09:00
David Rodríguez
d2087f1cde [rubygems/rubygems] Extract an install_file_list helper
5106ea4582
2020-05-08 14:13:29 +09:00
David Rodríguez
41b288476e [rubygems/rubygems] Move helper to private section
fb824b7a81
2020-05-08 14:13:29 +09:00
David Rodríguez
d59b92221d [rubygems/rubygems] Rename method to clarify
6dc76146ad
2020-05-08 14:13:29 +09:00
David Rodríguez
b1541606a2 [rubygems/rubygems] Fix incorrect gem uninstall --all message
Currently `gem uninstall --all` shows the following incorrect message
after completion:

```
INFO:  Uninstalled all gems in
```

Now it shows something that actually makes sense like:

```
INFO:  Uninstalled all gems in /home/deivid/Code/rubygems/tmp/test_rubygems_6986/gemhome
```

8fa05e8f8c
2020-05-08 14:13:29 +09:00
Thomas McDonald
22030fe508 [rubygems/rubygems] Refactor duplicate metadata logic
1e5ef177ac
2020-05-08 14:13:29 +09:00
Thomas McDonald
856f2f31ff [rubygems/rubygems] Remove unnecessary code
`@host` _could_ be `nil` at this point, but only if all the conditions
above for setting `@host` were `nil`. In that case, it is guaranteed
to `default_gem_server` metadata is `nil` since it's one of the
branches in that condition. So this code would just be setting an
already `nil` variable to `nil`. Hence, not needed.

e3ccff3c5c
2020-05-08 14:13:29 +09:00
Thomas McDonald
12ac0fa939 [rubygems/rubygems] Simplify host switching logic
This block was a branch and variable heavy way of saying use the
user-provided host if available, or fall-back to the default host if
none of the other options match. IMO the resultant single-if condition
is clearer in intentions

42dbb71cfa
2020-05-08 14:13:29 +09:00
bronzdoc
7db538a7c9 [rubygems/rubygems] Rename version horizon deprecation methods
6afd914fda
2020-05-08 07:38:50 +09:00
bronzdoc
ff37dd7e9e [rubygems/rubygems] Modify files to use new version horizon deprecations
4fe5bb5bf3
2020-05-08 07:38:50 +09:00
Hiroshi SHIBATA
de58dfc911 [rubygems/rubygems] Removed the depdendency of English library
English.rb is extracted to the default gems at
  2c5764ec22

532f488c0b
2020-04-28 10:56:14 +09:00
David Rodríguez
ba9dcdab36
[rubygems/rubygems] Enable Style/PercentLiteralDelimiters cop in rubygems
So it matches the style used by bundler.

ab0580fd65
2020-03-30 12:42:10 +09:00
David Rodríguez
96064e6f1c
Sync rubygems with current master (#2889) 2020-03-24 15:39:24 +09:00
Hiroshi SHIBATA
bd0a02d143
Revert to remove the query command of rubygems.
The original commit was https://github.com/rubygems/rubygems/pull/3119
2020-02-06 21:57:18 +09:00
David Rodríguez
054d99d95b
[rubygems/rubygems] Allow releasing with a rubygems pre version
This condition is too restrictive in my opinion. If a user has a pre
version of rubygems installed, she should be fully responsible for it,
and we shouldn't restrict any functionality.

Also, why is a new prerelease disallowed but an old prelease allowed, or
why is 2.0.0.rc2 explictly whitelisted? I believe this kind of
exceptions are one more reason to actually permit this.

7f77a77620
2020-02-06 21:57:17 +09:00
Hiroshi SHIBATA
600a715c9b
Merge the current master branch of rubygems/rubygems.
Just started to develop RubyGems 3.2.0.
2020-02-01 11:14:57 +09:00
Hiroshi SHIBATA
e672494cd7
Merge RubyGems 3.1.2 2019-12-20 11:50:32 +09:00
Hiroshi SHIBATA
82cc2843a9
Prepare to release RubyGems 3.1.0 final version. 2019-12-13 20:19:33 +09:00
Hiroshi SHIBATA
7d463e360b Merge RubyGems 3.1.0.pre3
* Fix gem pristine not accounting for user installed gems. Pull request
    #2914 by Luis Sagastume.
  * Refactor keyword argument test for Ruby 2.7. Pull request #2947 by
    SHIBATA Hiroshi.
  * Fix errors at frozen Gem::Version. Pull request #2949 by Nobuyoshi
    Nakada.
  * Remove taint usage on Ruby 2.7+. Pull request #2951 by Jeremy Evans.
  * Check Manifest.txt is up to date. Pull request #2953 by David Rodríguez.
  * Clarify symlink conditionals in tests. Pull request #2962 by David
    Rodríguez.
  * Update command line parsing to work under ps. Pull request #2966 by
    David Rodríguez.
  * Properly test `Gem::Specifications.stub_for`. Pull request #2970 by
    David Rodríguez.
  * Fix Gem::LOADED_SPECS_MUTEX handling for recursive locking. Pull request
    #2985 by MSP-Greg.
2019-11-11 16:59:49 +09:00
bronzdoc
73574756f9 [rubygems/rubygems] Add missing parentheses
f5972338e0
2019-09-05 18:43:37 +09:00
bronzdoc
92be07b1e1 [rubygems/rubygems] Remove unnecessary gem_name method
d1bb122651
2019-09-05 18:43:29 +09:00
bronzdoc
b11cfed4c4 [rubygems/rubygems] Error out if there are multiple gemspecs and no gemspec is specified
547947bbf0
2019-09-05 18:43:21 +09:00
bronzdoc
a02da1012b [rubygems/rubygems] Build the first gemspec we found if no gemspec is specified
ab186266b7
2019-09-05 18:42:56 +09:00
bronzdoc
bcf51dd763 [rubygems/rubygems] Improve gemspec assignment and error message
dc70c5a192
2019-09-05 18:42:49 +09:00
bronzdoc
68937fe0e4 [rubygems/rubygems] Make passing a gem name to be optional
4ba4ffebbe
2019-09-05 18:42:41 +09:00
bronzdoc
95326150fa [rubygems/rubygems] Move build gem logic to its own method
a16eacd650
2019-09-05 18:42:33 +09:00
Jeremy Evans
d08e1004e0 Fix keyword argument separation issues in lib
Mostly requires adding ** in either calls or method definitions.
2019-08-30 12:39:31 -07:00
bronzdoc
89ad5df979
[rubygems/rubygems] Replace domain parameter in Gem::Command#show_lookup_failure with a parameter to suppress suggestions
760b7d834f
2019-08-17 07:35:48 +09:00
bronzdoc
a51661d378
[rubygems/rubygems] Drop support for 'gem env packageversion'
be962ca0c4
2019-07-31 07:47:02 +08:00
Vít Ondruch
a3b784b3a0
[rubygems/rubygems] Move default specifications dir definition out of BasicSpecification.
This was never the right place. The method got there just by evolution,
not by design. Move it within default methods, where it suits better.

Since this method is presumably used just internally, it should be safe
to deprecate it and remove later.

0c0dd9458a
2019-07-31 07:47:02 +08:00
bronzdoc
6bd7772361
[rubygems/rubygems] Rename Gem::Package.metadata to Gem::Package.raw_spec
a76f25dff0
2019-07-31 07:47:01 +08:00
bronzdoc
688ccc9602
[rubygems/rubygems] Move metadata method to Gem::Package
2c9cfcb666
2019-07-31 07:47:01 +08:00
bronzdoc
a7bce01175
[rubygems/rubygems] Remove unnecessary &&= operator
a10b5265d7
2019-07-31 07:47:01 +08:00
bronzdoc
8b91a6d0a0
[rubygems/rubygems] Remove unnecessary TODO comment
ad7e379f79
2019-07-31 07:47:01 +08:00
Nobuyoshi Nakada
5a840517ae
Fix broken gem unpack
* lib/rubygems/commands/unpack_command.rb: 'rubygems/package' is
  required here, to fix broken `gem unpack` command.
2019-06-08 18:44:18 +09:00
Hiroshi SHIBATA
3776c48cf4 Revert "require rubygems/package where used"
This reverts commit b76630f73e.

  It fails with `make test-bundler BUNDLER_SPECS=runtime/setup_spec.rb:1204`
2019-06-08 13:49:37 +09:00
Nobuyoshi Nakada
b76630f73e
require rubygems/package where used
* lib/rubygems/commands/unpack_command.rb: 'rubygems/package' is
  required.  fix the failure of `gem unpack` command.

* lib/rubygems/source/local.rb: ditto.

* lib/rubygems/source/specific_file.rb: ditto.
2019-06-07 22:48:45 +09:00
Hiroshi SHIBATA
56660de3c6 Merge rubygems master from upstream.
I picked the commit from 3c469e0da538428a0ddd94f99aa73c32da22e8ba
2019-06-01 13:50:41 +03:00
David Rodríguez
d0a5467320 Update rubygems with latest upstream changes
Closes: https://github.com/ruby/ruby/pull/2154
2019-04-28 11:07:45 +09:00
hsbt
f28be7e02d Merge rubygems/rubygems from upstream.
The current master branch is
  97b264f0fa

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67415 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2019-04-02 11:48:18 +00:00
hsbt
4c1952f4bf Ignore to handle the different platform
When `GEM_HOME` was shared with CRuby and JRuby. RubyGems try to
  handle both platforms. It should be ignored the different platform.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67190 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2019-03-07 11:24:48 +00:00
hsbt
08f8cfe14e Merge RubyGems upstream: 56c0bbb69e4506bda7ef7f447dfec5db820df20b
It fixed the multiple vulnerabilities.
  https://blog.rubygems.org/2019/03/05/security-advisories-2019-03.html

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67168 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2019-03-05 03:32:58 +00:00
hsbt
4ae3df42f7 Merge RubyGems master@9be7858f7f17eae3058204f3c03e4b798ba18b9c
This version contains the some style changes by RuboCop.

    * 9d810be0ed
    * 61ea98a727
    * 795893dce3
    * 9be7858f7f

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67074 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2019-02-14 12:59:03 +00:00
hsbt
3dc6efbe9c Merge rubygems master targeted RubyGems 3.1.0.
1172320540

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2019-01-22 06:28:04 +00:00
hsbt
ae19a18996 Merge RubyGems 3.0.1 from rubygems/rubygems.
It fixed the issues of RubyGems 3.0.0.
  https://blog.rubygems.org/2018/12/23/3.0.1-released.html

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66499 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-12-23 00:20:49 +00:00
hsbt
7f9bf068fc Merge rubygems@21f12a8 from upstream.
* [BudlerVersionFinder] set .filter! and .compatible? to match only on major versions https://github.com/rubygems/rubygems/pull/2515
  * Fix broken symlink that points to ../* https://github.com/rubygems/rubygems/pull/2516

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66347 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-12-12 05:07:50 +00:00
hsbt
7a46a3b941 Merge rubygems-3.0.0.beta3.
* [GSoC] Multi-factor feature for RubyGems https://github.com/rubygems/rubygems/pull/2369

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66118 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-12-01 11:01:00 +00:00
hsbt
5dbc6583c9 Merge rubygems upstream from 2c499655f2
https://github.com/rubygems/rubygems/pull/2493

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66065 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-11-28 03:08:14 +00:00
hsbt
5335ce0e06 Merge master branch from rubygems/rubygems upstream.
* Enable Style/MethodDefParentheses in Rubocop
    https://github.com/rubygems/rubygems/pull/2478
  * Enable Style/MultilineIfThen in Rubocop
    https://github.com/rubygems/rubygems/pull/2479
  * Fix required_ruby_version with prereleases and improve error message
    https://github.com/rubygems/rubygems/pull/2344
  * Fix bundler rubygems binstub not properly looking for bundler
    https://github.com/rubygems/rubygems/pull/2426

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-11-21 10:20:47 +00:00
hsbt
615ac35934 Merge rubygems master branch from github.com/rubygems/rubygems.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65294 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-22 00:27:02 +00:00