Commit graph

191 commits

Author SHA1 Message Date
David Rodríguez
bd9a6ba4ef [rubygems/rubygems] Remove unintended extra space
1cc02930f3
2020-06-05 07:32:42 +09:00
Hiroshi SHIBATA
9f7bfba54f Revert "Fix a error in a before(:suite) hook"
This reverts commit 67d2a715ca.
2020-06-05 07:32:42 +09:00
Hiroshi SHIBATA
1ab410caf8 Revert "Fix a failure in bundle version with version outputs the version with build metadata"
This reverts commit fcc8be0198.
2020-06-05 07:32:42 +09:00
Kazuhiro NISHIYAMA
fcc8be0198
Fix a failure in bundle version with version outputs the version with build metadata
```
  1) bundle version with version outputs the version with build metadata
     Failure/Error: expect(out).to match(/\ABundler version #{Regexp.escape(Bundler::VERSION)} \(\d{4}-\d{2}-\d{2} commit #{COMMIT_HASH}\)\z/)

       expected "Bundler version 2.2.0.dev (2020-05-25 commit )" to match /\ABundler version 2\.2\.0\.dev \(\d{4}-\d{2}-\d{2} commit (?-mix:unknown|[a-fA-F0-9]{7,})\)\z/
       Diff:
       @@ -1,2 +1,2 @@
       -/\ABundler version 2\.2\.0\.dev \(\d{4}-\d{2}-\d{2} commit (?-mix:unknown|[a-fA-F0-9]{7,})\)\z/
       +"Bundler version 2.2.0.dev (2020-05-25 commit )"

       Commands:
       $ /home/user/snapshot-master/ruby -I/home/user/snapshot-master/spec/bundler -r/home/user/snapshot-master/spec/bundler/support/artifice/fail.rb -r/home/user/snapshot-master/spec/bundler/support/hax.rb /home/user/snapshot-master/tmp/1/gems/system/bin/bundle version
       Bundler version 2.2.0.dev (2020-05-25 commit )
       # $? => 0
```
2020-05-25 20:08:30 +09:00
Kazuhiro NISHIYAMA
67d2a715ca
Fix a error in a before(:suite) hook
703745101 (step):16:27
```
An error occurred in a `before(:suite)` hook.
Failure/Error: contents = File.read(version_file)

Errno::ENOENT:
  No such file or directory @ rb_sysopen - /home/runner/work/actions/actions/snapshot-master/tmp/1/bundler-2.2.0.dev/lib/bundler/version.rb
```
2020-05-25 20:08:30 +09:00
Hiroshi SHIBATA
93ebf9643d Revert 1f011cccb1 2020-05-22 20:32:30 +09:00
Hiroshi SHIBATA
c7ebeb7eda Sync Bundler PR #3624 2020-05-22 20:32:30 +09:00
Kazuhiro NISHIYAMA
6c1a51dae8
Skip some tests if extracted from tarball (again)
Fix up previous commit

ref
9aa75795f9,
38002a8adb, and
0e60b59d58
2020-05-19 00:58:33 +09:00
Kazuhiro NISHIYAMA
1f011cccb1
Skip some tests if extracted from tarball (again)
ref 9aa75795f9
2020-05-18 23:18:44 +09:00
Hiroshi SHIBATA
d4acf254e3 Use the gemspec in build_dir directly 2020-05-14 09:11:28 +09:00
Hiroshi SHIBATA
fcb5a9ee46 Resolved the file path of gemspec for ruby core repository 2020-05-13 07:54:37 +09:00
Hiroshi SHIBATA
5b634afe4c Added test_gems.rb for setup dependencies 2020-05-13 07:54:37 +09:00
Hiroshi SHIBATA
0e60b59d58 Update the bundler version with master branch 2020-05-13 07:54:37 +09:00
Hiroshi SHIBATA
13f4f07f21 Merge bundler-2.1.4 2020-01-08 18:00:32 +09:00
Sutou Kouhei
e1c363f847
[bundler/bundler] Add ruby2_keywords
29d932d72d
2020-01-01 07:41:37 +09:00
Hiroshi SHIBATA
286cb3395f Fixed test failures with gem command path on ruby core repo. 2019-12-15 16:41:10 +09:00
Hiroshi SHIBATA
38002a8adb Prepare to release bundler-2.1.0 2019-12-15 16:41:10 +09:00
Kazuhiro NISHIYAMA
fea24bbfdb Fix glob base in bundler.gemspec 2019-11-19 00:29:10 +09:00
Kazuhiro NISHIYAMA
9aa75795f9 Skip some tests if extracted from tarball 2019-11-19 00:29:10 +09:00
Hiroshi SHIBATA
bb9ecd026a Merge Bundler 2.1.0.pre3 released version 2019-11-13 10:19:51 +09:00
Hiroshi SHIBATA
7585bc3187 Merge Bundler 2.1.0.pre.3
Features:
    - Add caller information to some deprecation messages to make them easier to fix [#7361](https://github.com/bundler/bundler/pull/7361)
    - Reconcile `bundle cache` vs `bundle package` everywhere. Now in docs, CLI help and everywhere else `bundle cache` is the preferred version and `bundle package` remains as an alias [#7389](https://github.com/bundler/bundler/pull/7389)
    - Display some basic `bundler` documentation together with ruby's RDoc based documentation [#7394](https://github.com/bundler/bundler/pull/7394)

  Bugfixes:
    - Fix typos deprecation message and upgrading docs [#7374](https://github.com/bundler/bundler/pull/7374)
    - Deprecation warnings about `taint` usage on ruby 2.7 [#7385](https://github.com/bundler/bundler/pull/7385)
    - Fix `--help` flag not correctly delegating to `man` when used with command aliases [#7388](https://github.com/bundler/bundler/pull/7388)
    - `bundle add` should cache newly added gems if an application cache exists [#7393](https://github.com/bundler/bundler/pull/7393)
    - Stop using an insecure folder as a "fallback home" when user home is not defined [#7416](https://github.com/bundler/bundler/pull/7416)
    - Fix `bundler/inline` warning about `Bundler.root` redefinition [#7417](https://github.com/bundler/bundler/pull/7417)
2019-11-11 18:56:25 +09:00
Nobuyoshi Nakada
4419b5dbc2
The investigation is going on... 2019-08-21 13:31:22 +09:00
Hiroshi SHIBATA
1c2774526e
[bundler/bundler] Share test fixtures with parallel_tests
a38161c5be
2019-08-21 08:10:49 +09:00
Hiroshi SHIBATA
10011f4371
[bundler/bundler] Try to use RunTimeLogger for parallel_tests
faccc522d1
2019-08-21 08:10:48 +09:00
David Rodríguez
ace88852f2
[bundler/bundler] Parallelize test suite
23007cb107
2019-08-21 08:10:48 +09:00
David Rodríguez
ede77d82e7
[bundler/bundler] Fix a couple of typos
52b6b94068
2019-08-21 07:58:46 +09:00
Nobuyoshi Nakada
dd58c4ba35
Investigation of a sporadic error at Github Actions 2019-08-20 16:07:43 +09:00
David Rodríguez
5a384e2c08 Fix some bundler specs (#2380)
* These seem to consistenly pass already

* Show actual command when running `make test-bundler`

Current the setup command that installs the necessary gems for testing
bundler was printed, but not the actual command that runs the tests.
That was a bit confusing.

* Borrow trick from setproctitle specs

* A title that long doesn't get set sometimes

No idea why, but the test doesn't need that the title is that long.

* Fix most gem helper spec ruby-core failures

* Fix the rest of the gem helper failures

* Fix version spec by improving the assertion

* Remove unnecessary `BUNDLE_RUBY` environment var

We can use `RUBY` when necessary, and `BUNDLE_RUBY` is not a good name
because bundler considers `BUNDLE_*` variables as settings.

* Rename `BUNDLE_GEM` to `GEM_COMMAND`

This is more descriptive I think, and also friendlier for bundler
because `BUNDLE_` env variables are interpreted by bundler as settings,
and this is not a bundler setting.

This fixes one bundler spec failure in config specs against ruby-core.

* Fix quality spec when run in core

Use the proper path helper.

* Fix dummy lib builder to never load default gems

If a dummy library is named as a default gem, when requiring the library
from its executable, the default gem would be loaded when running from
core, because in core all default gems share path with bundler, and thus
they are always in the $LOAD_PATH. We fix the issue by loading lib
relatively inside dummy lib executables.

* More exact assertions

Sometimes I have the problem that I do some "print debugging" inside
specs, and suddently the spec passes. This happens when the assertion is
too relaxed, and the things I print make it match, specially when they
are simple strings like "1.0" than can be easily be part of gem paths
that I print for debugging.

I fix this by making a more exact assertion.

* Detect the correct shebang when ENV["RUBY"] is set

* Relax assertion

So that the spec passes even if another paths containing "ext" are in
the load path. This works to fix a ruby-core issue, but it's a better
assertion in general. We just want to know that the extension path was
added.

* Use folder structure independent path helper

It should fix this spec for ruby-core.

* Fix the last failing spec on ruby-core

* Skip `bundle open <default_gem>` spec when no default gems
2019-08-20 09:46:31 +09:00
David Rodríguez
683f9e1dbf [bundler/bundler] No need to activate the fileutils default gem
The version we're vendoring actually relaxed this restriction back to
2.3.0+, so we can always use the vendored version.

d366cbfe5d
2019-08-18 13:45:45 +09:00
David Rodríguez
4756c5f7e7 [bundler/bundler] Remove unnecessary rubygems monkeypatch
Instead, make sure we always load the local copy of bundler during
specs, and never end up using the default copy.

ac655ffeda
2019-08-18 13:45:35 +09:00
David Rodríguez
f753961611 [bundler/bundler] Remove a bunch of unneeded rubygems requires
f9cb39e614
2019-08-18 13:44:46 +09:00
David Rodríguez
08c58e3c0d
[bundler/bundler] Extract a gemspec_dir helper
71a29e286a
2019-08-17 17:08:51 +09:00
David Rodríguez
a2d7c97a91
[bundler/bundler] Extract yet another helper method
948a863bd8
2019-08-17 17:08:51 +09:00
David Rodríguez
4318405609
[bundler/bundler] Extract a root_gemspec local variable
a4beba4cbf
2019-08-17 17:08:51 +09:00
David Rodríguez
09455301ef
[bundler/bundler] Extract a with_root_gemspec helper
f20c2bdf6a
2019-08-17 17:08:51 +09:00
David Rodríguez
9925e1a10f
[bundler/bundler] Remove unneeded to_s calls
They are implicit inside `gem_command!`.

6bdb13c899
2019-08-17 17:08:51 +09:00
David Rodríguez
f88237623f
[bundler/bundler] Consistently use Path over Spec::Path
a4cca66b79
2019-08-17 17:08:51 +09:00
David Rodríguez
aef5509139
[bundler/bundler] Extract single gem installation logic
7888d621c8
2019-08-17 17:08:51 +09:00
David Rodríguez
20af44c277
[bundler/bundler] Unalias install_gem
Since I plan to reuse it for something else.

5379382198
2019-08-17 17:08:50 +09:00
David Rodríguez
6506993462
[bundler/bundler] Use join consistently
096e53dfe6
2019-08-17 17:08:50 +09:00
David Rodríguez
6a299906b4
[bundler/bundler] Extract a lib_tracked_files path helper
028dc46f5a
2019-08-17 17:08:50 +09:00
David Rodríguez
c896f71577
[bundler/bundler] Extract a tracked_files path helper
d35e31d2e0
2019-08-17 17:08:50 +09:00
David Rodríguez
122bc65042
[bundler/bundler] Reuse gem_bin helper inside gem_command
The logic for choosing `gem_bin` should work here too even if it's not
identical.

6ca0271b27
2019-08-17 17:08:50 +09:00
David Rodríguez
30a4ec1fee
[bundler/bundler] Always use --backtrace when invoking gem CLI
For debuggability.

ac3e8db658
2019-08-17 17:08:50 +09:00
David Rodríguez
91c63828f7
[bundler/bundler] Extract a gem_bin path helper
8eedbecac0
2019-08-17 17:08:50 +09:00
David Rodríguez
63d78afc2d
[bundler/bundler] Remove more dead code
17d4d0de8e
2019-08-17 17:08:50 +09:00
David Rodríguez
2e6509498c
[bundler/bundler] Remove dead code
cae948f514
2019-08-17 17:08:50 +09:00
David Rodríguez
3bebdda649
[bundler/bundler] Remove unnecessary rubygems require
039604ff95
2019-08-17 17:08:50 +09:00
David Rodríguez
745b286161
[bundler/bundler] Move lib helper together with path helpers
f2df73bdb4
2019-08-17 17:08:49 +09:00
David Rodríguez
50a91fcd10
[bundler/bundler] Reuse lib method
4589a57852
2019-08-17 17:08:49 +09:00