Commit graph

191 commits

Author SHA1 Message Date
Hiroshi SHIBATA
1a60012612 [rubygems/rubygems] util/rubocop -A --only Lint/RescueException
e8a5db50af
2023-03-23 17:18:49 +09:00
Nobuyoshi Nakada
348412c7fa [rubygems/rubygems] Use indented heredoc
085d2776d8
2023-03-22 21:21:08 +00:00
Hiroshi SHIBATA
5211900d37 util/rubocop -A --only Style/SymbolProc 2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
0373615948 util/rubocop -A --only Layout/SpaceInsideArrayLiteralBrackets 2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
6ad269dc39 [rubygems/rubygems] util/rubocop -A --only Style/RescueStandardError
80b57da926
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
70164eec0f [rubygems/rubygems] util/rubocop -A --only Style/RescueModifier
b490379eab
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
38664ede7e [rubygems/rubygems] util/rubocop -A --only Style/NonNilCheck
2b056b25c3
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
d2cebb4e31 [rubygems/rubygems] util/rubocop -A --only Style/NumericLiterals
860669b08a
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
567db6064b [rubygems/rubygems] util/rubocop -A --only Style/NestedParenthesizedCalls
a875fdb535
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
3d4c3f9e4f [rubygems/rubygems] util/rubocop -A --only Style/ParallelAssignment
5c88c77873
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
4bb5ce8188 [rubygems/rubygems] util/rubocop -A --only Style/StringLiteralsInInterpolation
cb554f6eb7
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
7c1d590a8a [rubygems/rubygems] util/rubocop -A --only Layout/SpaceBeforeComma
4a5b70b508
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
23150e0274 [rubygems/rubygems] util/rubocop -A --only Layout/MultilineHashBraceLayout
bf33d106d0
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
05208c3875 [rubygems/rubygems] util/rubocop -A --only Lint/UnusedBlockArgument
d8efd919db
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
5e27d82dd0 [rubygems/rubygems] rubocop -a test/rubygems/test_gem.rb
4d20ed7e32
2023-03-10 05:16:52 +00:00
Hiroshi SHIBATA
f1c9f89ff8 [rubygems/rubygems] Disable side-effect of GEM_HOME configuration
c43328ab03
2023-03-10 05:16:52 +00:00
Josef Šimánek
dc33d32f12
Use proper memoized var name for Gem.state_home. 2023-03-07 16:52:28 +09:00
David Rodríguez
022acb9593 [rubygems/rubygems] Don't load Bundler from RubyGems tests
c2e4cb7b5e
2023-01-31 10:49:08 +09:00
Hiroshi SHIBATA
bbe56a6437 Merge RubyGems/Bundler master
from bfb0ae6977
2022-12-12 10:49:43 +09:00
David Rodríguez
b7a61cb485 [rubygems/rubygems] Revert "Cleaup unnecessary code"
Unclear why, but 2e05dadbc5 created some
warnings in ruby-core CI, so let's revert it.

729ce3a6e1
2022-10-03 19:54:24 +09:00
David Rodríguez
ac56e5c1ab [rubygems/rubygems] Put bundler gemspec stub at the right place
So that it's found when needed, rather than dynamically modifying
loaded stubs and thus messing with RubyGems internals.

cd3e7cb9e5
2022-09-29 03:41:53 +09:00
David Rodríguez
668e78f01b [rubygems/rubygems] Only activate bundler when needed
Loading Bundler beforehand was actually replacing ENV with a backup of
the pre-Bundler environment through `Bundler::EnvironmentPreserver`. I
think that was making a bug in `ENV.replace` not bite our tests, because
Bundler includes proper patches to workaround that issue. So this commit
also includes these patches in RubyGems tests.

8e079149b9
2022-09-29 03:41:52 +09:00
David Rodríguez
00a040dda3 [rubygems/rubygems] Little refactor to keep things consistent
3934deb4e4
2022-09-29 03:41:51 +09:00
David Rodríguez
874a2bf17c [rubygems/rubygems] Remove unnecessary ensure
6c0c02c533
2022-09-29 03:41:51 +09:00
David Rodríguez
b9c426eaea [rubygems/rubygems] Remove unnecessary constant
4bd77488ad
2022-09-29 03:41:50 +09:00
David Rodríguez
1e5597532a [rubygems/rubygems] Cleaup unnecessary code
2e05dadbc5
2022-09-29 03:41:49 +09:00
David Rodríguez
5222a89ab6 [rubygems/rubygems] Unskip stuff that now works on JRuby
d86a5ae2eb
2022-09-29 03:41:49 +09:00
David Rodríguez
24fd2f73d0 Resync Bundler & RubyGems 2022-09-08 11:25:03 +09:00
Takuya Noguchi
d7ffd3fea4
RubyGems: Enable Style/StringLiterals cop
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
2022-07-22 12:07:23 +09:00
Hiroshi SHIBATA
aeea88174d
Merge RubyGems and Bundler HEAD
125415593e
2022-05-20 17:32:19 +09:00
Hiroshi SHIBATA
1056489ea3 Merge 3f7d0352e8 2022-04-28 19:08:49 +09:00
Hiroshi SHIBATA
678d58c850 Merge rubygems master 1e4eda741d732ca1bd7031aef0a16c7348adf7a5 2022-04-28 19:08:49 +09:00
David Rodríguez
3006451f65 [rubygems/rubygems] Privatize some test utils
386b3b85ca
2022-01-15 00:00:09 +09:00
Hiroshi SHIBATA
fb1ab27f53 Merge RubyGems-3.3.1 and Bundler-2.3.1 2021-12-23 09:44:45 +09:00
Kevin Logan
eb2d3c19fe [rubygems/rubygems] Properly fetch Gem#latest_spec_for with multiple sources
a93ec63df3
2021-12-10 20:54:29 +09:00
Nobuyoshi Nakada
a4f2aafd3a [rubygems/rubygems] Remove save_loaded_features
f5e408f83d
2021-10-14 05:03:36 +09:00
David Rodríguez
590d2222a0 [rubygems/rubygems] Remove helper method not buying us much
81dc685d20
2021-08-31 19:06:14 +09:00
David Rodríguez
d01c3111c2 [rubygems/rubygems] Remove MacOS specific extra GEM_PATH
They should properly configure `GEM_PATH` instead.

3bd9ae33ca
2021-08-31 19:06:14 +09:00
David Rodríguez
9fa5c4cd07 [rubygems/rubygems] Also load user installed rubygems plugins
82960c262f
2021-08-31 19:06:14 +09:00
David Rodríguez
2d0d1c339a [rubygems/rubygems] Recommend bundle install rather than gem install -g
4028cbc408
2021-08-31 19:06:14 +09:00
David Rodríguez
76b77d9275 [rubygems/rubygems] Refactor reseting RUBYGEMS_GEMDEPS in tests
91dca11112
2021-08-31 19:06:14 +09:00
David Rodríguez
87dfb55c16 [rubygems/rubygems] Use Gem.use_gemdeps only from binstubs
The previous behavior was to automatically require `bundler/setup`
everytime `rubygems` was required, which I think was too much.

b25379a295
2021-08-31 19:06:14 +09:00
David Rodríguez
b6c082fd09 [rubygems/rubygems] Remove misleading comment
When I read, I thought the assertion was incorrect. It's doing the right
thing, though.

e72c27367a
2021-08-31 19:06:14 +09:00
David Rodríguez
19d77a1cfc [rubygems/rubygems] Remove unnecessary spec manipulation
c7c00c280f
2021-08-31 19:06:14 +09:00
David Rodríguez
b17cdad2f8 [rubygems/rubygems] Remove redundant part of error message
It doesn't really add much, in my opinion. We want to be helpful, but
also concise when possible.

9d56009cf7
2021-08-31 19:06:14 +09:00
Yusuke Endoh
b957c3dbcb [rubygems/rubygems] Rename test/rubygems/test_{case,utilities}.rb to avoid "test_" prefix
This changes "test/rubygems/test_case.rb" to "test/rubygems/helper.rb",
and "test/rubygems/test_utilities.rb" to "test/rubygems/utilities.rb".

The two files are a helper for tests, not test files. However, a file
starting with "test_" prefix is handled as a test file directly loaded
by test-unit because Rakefile specifies:

```
t.test_files = FileList['test/**/test_*.rb']
```

Directly loading test/rubygems/test_utilities.rb caused "uninitialized
constant Gem::TestCase". This issue was fixed by
59c6820971, but the fix caused a
"circular require" warning because test_utilities.rb and test_case.rb
are now requiring each other.

Anyway, adding "test_" prefix to a test helper file is confusing, so
this changeset reverts the fix and solve the issue by renaming them.

6460e018df
2021-06-03 12:23:22 +09:00
Hiroshi SHIBATA
e487ba7dda
[rubygems/rubygems] Use pend instead of skip 2021-05-28 12:33:16 +09:00
David Rodríguez
f7732ae2eb [rubygems/rubygems] Require the new files in test/ relatively
c77868a555
2021-05-28 11:53:09 +09:00
Hiroshi SHIBATA
c30594bb0c [rubygems/rubygems] Use assert_raise instead of assert_raises
769e87f011
2021-05-12 17:24:43 +09:00
Hiroshi SHIBATA
3948be3503 [rubygems/rubygems] Use assert_path_exist and assert_path_not_exist instead of assert_path_exists and refute_path_exists
a7c93558c3
2021-05-12 17:24:43 +09:00