Commit graph

77079 commits

Author SHA1 Message Date
Hiroshi SHIBATA
d8c5fa963f [rubygems/rubygems] util/rubocop -A --only Style/YodaCondition
3594945391
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
66bd2c1a1c [rubygems/rubygems] util/rubocop -A --only Style/CommentAnnotation
4e77a1d1d5
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
52ea7afa5f [rubygems/rubygems] util/rubocop -A --only Style/NegatedIf
aa95ee27a2
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
9ab860f9af [rubygems/rubygems] util/rubocop -A --only Style/ColonMethodCall
823113f39e
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
bd57322bfe [rubygems/rubygems] util/rubocop -A --only Style/DefWithParentheses
91391ceedf
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
03b82d1865 [rubygems/rubygems] util/rubocop -A --only Style/SingleLineMethods
fa2e835ed2
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
d2cebb4e31 [rubygems/rubygems] util/rubocop -A --only Style/NumericLiterals
860669b08a
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
712d6e675b [rubygems/rubygems] util/rubocop -A --only Style/RedundantInterpolation
add44e56eb
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
0b632b9cdd [rubygems/rubygems] util/rubocop -A --only Style/ClassCheck
1c3356a872
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
567db6064b [rubygems/rubygems] util/rubocop -A --only Style/NestedParenthesizedCalls
a875fdb535
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
3d4c3f9e4f [rubygems/rubygems] util/rubocop -A --only Style/ParallelAssignment
5c88c77873
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
4bb5ce8188 [rubygems/rubygems] util/rubocop -A --only Style/StringLiteralsInInterpolation
cb554f6eb7
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
83f9aa8f02 [rubygems/rubygems] util/rubocop -A --only Style/Alias
fba6e94de9
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
f4d1f660d0 [rubygems/rubygems] util/rubocop -A --only Layout/SpaceInsideRangeLiteral
426dd97a31
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
ae81ff0c9b [rubygems/rubygems] util/rubocop -A --only Layout/MultilineBlockLayout
9aa6101942
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
9a1269eaaa [rubygems/rubygems] util/rubocop -A --only Layout/MultilineArrayBraceLayout
f4f45ab27e
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
26d6604343 [rubygems/rubygems] util/rubocop -A --only Layout/MultilineMethodCallBraceLayout
acb0548bf6
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
41f304d5bf [rubygems/rubygems] util/rubocop -A --only Layout/SpaceInsideStringInterpolation
a06f8ae3bb
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
ce21ce6f23 [rubygems/rubygems] util/rubocop -A --only Layout/FirstArgumentIndentation
0542726fd3
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
3233b1fe3f [rubygems/rubygems] util/rubocop -A --only Layout/SpaceInLambdaLiteral
e76088b699
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
f8daae91c4 [rubygems/rubygems] util/rubocop -A --only Layout/SpaceBeforeSemicolon
c92c6d8e85
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
4b285e5c6f [rubygems/rubygems] util/rubocop -A --only Layout/AssignmentIndentation
8e64298989
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
9ffd73523d [rubygems/rubygems] util/rubocop -A --only Layout/EmptyLinesAroundExceptionHandlingKeywords
ad1fe68d97
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
583fbc627c [rubygems/rubygems] util/rubocop -A --only Layout/EmptyLinesAroundModuleBody
48c88466b7
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
c480a0c46a [rubygems/rubygems] util/rubocop -A --only Layout/LeadingCommentSpace
4d680320e3
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
d9f92511ad [rubygems/rubygems] util/rubocop -A --only Layout/SpaceInsidePercentLiteralDelimiters
c6de27fc6d
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
85fd33c526 [rubygems/rubygems] util/rubocop -A --only Layout/SpaceInsideArrayPercentLiteral
75abd2e504
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
dab1d0ed20 [rubygems/rubygems] util/rubocop -A --only Layout/EmptyLineBetweenDefs
00117e69cc
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
7c1d590a8a [rubygems/rubygems] util/rubocop -A --only Layout/SpaceBeforeComma
4a5b70b508
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
23150e0274 [rubygems/rubygems] util/rubocop -A --only Layout/MultilineHashBraceLayout
bf33d106d0
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
ab2278eb34 [rubygems/rubygems] util/rubocop -A --only Lint/UselessAccessModifier
5070f90987
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
eb80f51c6d [rubygems/rubygems] util/rubocop -A --only Lint/RedundantStringCoercion
58e4885493
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
05208c3875 [rubygems/rubygems] util/rubocop -A --only Lint/UnusedBlockArgument
d8efd919db
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
7ab4ede4f5 [rubygems/rubygems] util/rubocop -A --only Performance/TimesMap
976a351f8b
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
139f0927f5 [rubygems/rubygems] util/rubocop -A --only Performance/DoubleStartEndWith
893da27e7c
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
65752b61e7 [rubygems/rubygems] util/rubocop -A --only Performance/Count
46d5d6d1d3
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
2eb99350f4 [rubygems/rubygems] Removed rubocop:disable detected by Lint/RedundantCopDisableDirective
07b0da6c24
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
2dddac0475 [rubygems/rubygems] util/rubocop -a test/rubygems/helper.rb and styling
fe331736d4
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
fe1b0661cb [rubygems/rubygems] Removed RUBY_PATCHLEVEL and modify condition for ruby_version
b420e287a3
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
b09973a995 [rubygems/rubygems] Also removed condition of RUBY_PATCHLEVEL
16f381be4b
2023-03-17 18:50:55 +09:00
Hiroshi SHIBATA
8e40d1e153 [rubygems/rubygems] RUBY_PATCHLEVEL was provided after Ruby 1.8.5
7750d5c460
2023-03-17 18:50:55 +09:00
David Rodríguez
a47c54131d [rubygems/rubygems] Remove ensure part in require
I've seen this error sometimes but never found it helpful, since the
culprit has never been thread/monitor related, so it just adds noise.

Right now I'm seeing an issue in CI where we seem to be crashing during
ensure and showing a weird backtrace:

```
#<Thread:0x000055821d7a73b8 /home/runner/work/rubygems/rubygems/lib/rubygems/request_set.rb:167 run> terminated with exception (report_on_exception is true):
/home/runner/work/rubygems/rubygems/lib/rubygems/platform.rb:141:in `==': undefined local variable or method `to_a' for false:FalseClass (NameError)
Did you mean?  to_s
	from /home/runner/work/rubygems/rubygems/lib/rubygems/core_ext/kernel_require.rb:168:in `!='
	from /home/runner/work/rubygems/rubygems/lib/rubygems/core_ext/kernel_require.rb:168:in `require'
	from /home/runner/work/rubygems/rubygems/lib/rubygems.rb:441:in `block in ensure_subdirectories'
	from /home/runner/work/rubygems/rubygems/lib/rubygems.rb:437:in `each'
	from /home/runner/work/rubygems/rubygems/lib/rubygems.rb:437:in `ensure_subdirectories'
	from /home/runner/work/rubygems/rubygems/lib/rubygems.rb:413:in `ensure_gem_subdirectories'
	from /home/runner/work/rubygems/rubygems/lib/rubygems/resolver/specification.rb:110:in `download'
	from /home/runner/work/rubygems/rubygems/lib/rubygems/request_set.rb:173:in `block (2 levels) in install'
```

Let's get this out of the picture in case that helps clarify the
culprit.

87ce40b70e
2023-03-17 18:50:55 +09:00
David Rodríguez
dd0f0a5e6e [rubygems/rubygems] Fix gem uninstall with --install-dir
ac23687353
2023-03-17 18:50:55 +09:00
David Rodríguez
123bedd295 [rubygems/rubygems] Extract some common logic to a test helper
ef4741b7cb
2023-03-17 18:50:55 +09:00
David Rodríguez
5733828734 [rubygems/rubygems] Fix rake check_manifest when rake is --user-installed'd
Otherwise we get

```
✗ rake TEST=test/rubygems/test_project_sanity.rb
Loaded suite /Users/deivid/.gem/ruby/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader
Started
E
============================================================================================================================================================================================================
Error: test_manifest_is_up_to_date(TestProjectSanity):
  RuntimeError: There was an error running `rake check_manifest`: /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems.rb:263:in `find_spec_for_exe': can't find gem rake (>= 0.a) with executable rake (Gem::GemNotFoundException)
  	from /Users/deivid/.asdf/installs/ruby/3.2.1/lib/ruby/site_ruby/3.2.0/rubygems.rb:282:in `activate_bin_path'
  	from /Users/deivid/.asdf/installs/ruby/3.2.1/bin/rake:25:in `<main>'
/Users/deivid/Code/rubygems/rubygems/test/rubygems/test_project_sanity.rb:27:in `test_manifest_is_up_to_date'
     24:
     25:         raise "Expected Manifest.txt to be up to date, but it's not. Run `rake update_manifest` to sync it."
     26:       else
  => 27:         raise "There was an error running `rake check_manifest`: #{out}"
     28:       end
     29:     end
     30:   end
============================================================================================================================================================================================================
.
Finished in 0.188192 seconds.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
2 tests, 1 assertions, 0 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications
50% passed
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
10.63 tests/s, 5.31 assertions/s
rake aborted!
```

29829933a6
2023-03-17 18:50:55 +09:00
David Rodríguez
37c2e903e8 [rubygems/rubygems] Show error when rake check_manifest fails for unknown reason
98de85c11e
2023-03-17 18:50:55 +09:00
David Rodríguez
8371c0eac4 [rubygems/rubygems] Fix incorrect error message when multiple platforms are locked
24d2bf9cb2
2023-03-17 18:50:55 +09:00
David Rodríguez
d5121992dc [rubygems/rubygems] Remove unnecessary specific_local_platform test helper
86b574824d
2023-03-17 18:50:55 +09:00
David Rodríguez
2d8b55fcd2 [rubygems/rubygems] Simplify lockfile_platforms helper
To make it easier to change the default platforms that get locked later.

255c4012ec
2023-03-17 18:50:55 +09:00
David Rodríguez
9492efbe71 [rubygems/rubygems] Remove unnecessary local helper
27ed6870ce
2023-03-17 18:50:55 +09:00