ruby/test/rubygems/test_gem_source.rb
David Rodríguez fe1bace43c [rubygems/rubygems] Fix gem install does-not-exist being super slow
Every time a gem is not found in the Compact Index API, RubyGems will
fallback to the full index, which is very slow. This is unnecessary
because both indexes should be providing the same gems, so if a gem
can't be found in the Compact Index API, it won't be found in the full
index.

We _do_ want a fallback to the full index, whenever the Compact Index
API is not implemented. To detect that, we check that the API responds
to the "/versions" endpoint, just like Bundler does.

Before:

```
$ time gem install fooasdsfafs
ERROR:  Could not find a valid gem 'fooasdsfafs' (>= 0) in any repository
gem  20,77s user 0,59s system 96% cpu 22,017 total
```

After:

```
$ time gem install fooasdsfafs
ERROR:  Could not find a valid gem 'fooasdsfafs' (>= 0) in any repository
gem  5,02s user 0,09s system 91% cpu 5,568 total
```

c0d6b9eea7
2024-09-06 18:44:37 +00:00

253 lines
7.4 KiB
Ruby

# frozen_string_literal: true
require_relative "helper"
require "rubygems/source"
class TestGemSource < Gem::TestCase
def tuple(*args)
Gem::NameTuple.new(*args)
end
def setup
super
@specs = spec_fetcher do |fetcher|
fetcher.spec "a", "1.a"
fetcher.gem "a", 1
fetcher.spec "a", 2
fetcher.spec "b", 2
end
@source = Gem::Source.new(@gem_repo)
end
def test_initialize_invalid_uri
assert_raise Gem::URI::InvalidURIError do
Gem::Source.new "git@example:a.git"
end
end
def test_initialize_git
repository = "git@example:a.git"
source = Gem::Source::Git.new "a", repository, nil, false
assert_equal repository, source.uri
end
def test_cache_dir_escapes_windows_paths
uri = Gem::URI.parse("file:///C:/WINDOWS/Temp/gem_repo")
root = Gem.spec_cache_dir
cache_dir = @source.cache_dir(uri).gsub(root, "")
assert !cache_dir.include?(":"), "#{cache_dir} should not contain a :"
end
def test_dependency_resolver_set_bundler_api
response = Gem::Net::HTTPResponse.new "1.1", 200, "OK"
response.uri = Gem::URI("http://example")
@fetcher.data["#{@gem_repo}versions"] = response
set = @source.dependency_resolver_set
assert_kind_of Gem::Resolver::APISet, set
end
def test_dependency_resolver_set_file_uri
empty_dump = Gem::Util.gzip("\x04\x08[\x05".b)
File.binwrite(File.join(@tempdir, "prerelease_specs.4.8.gz"), empty_dump)
File.binwrite(File.join(@tempdir, "specs.4.8.gz"), empty_dump)
source = Gem::Source.new "file://#{@tempdir}/"
set = source.dependency_resolver_set
assert_kind_of Gem::Resolver::IndexSet, set
end
def test_dependency_resolver_set_marshal_api
set = @source.dependency_resolver_set
assert_kind_of Gem::Resolver::IndexSet, set
end
def test_fetch_spec
a1 = @specs["a-1"]
spec_uri = "#{@gem_repo}#{Gem::MARSHAL_SPEC_DIR}#{a1.spec_name}"
spec = @source.fetch_spec tuple("a", Gem::Version.new(1), "ruby")
assert_equal a1.full_name, spec.full_name
cache_dir = @source.cache_dir Gem::URI.parse(spec_uri)
cache_file = File.join cache_dir, a1.spec_name
assert File.exist?(cache_file)
end
def test_fetch_spec_cached
a1 = @specs["a-1"]
spec_uri = "#{@gem_repo}/#{Gem::MARSHAL_SPEC_DIR}#{a1.spec_name}"
@fetcher.data["#{spec_uri}.rz"] = nil
cache_dir = @source.cache_dir Gem::URI.parse(spec_uri)
FileUtils.mkdir_p cache_dir
cache_file = File.join cache_dir, a1.spec_name
File.open cache_file, "wb" do |io|
Marshal.dump a1, io
end
spec = @source.fetch_spec tuple("a", Gem::Version.new(1), "ruby")
assert_equal a1.full_name, spec.full_name
end
def test_fetch_spec_platform
specs = spec_fetcher(&:legacy_platform)
spec = @source.fetch_spec tuple("pl", Gem::Version.new(1), "i386-linux")
assert_equal specs["pl-1-x86-linux"].full_name, spec.full_name
end
def test_fetch_spec_platform_ruby
spec = @source.fetch_spec tuple("a", Gem::Version.new(1), nil)
assert_equal @specs["a-1"].full_name, spec.full_name
spec = @source.fetch_spec tuple("a", Gem::Version.new(1), "")
assert_equal @specs["a-1"].full_name, spec.full_name
end
def test_load_specs
released = @source.load_specs(:released).map(&:full_name)
assert_equal %W[a-2 a-1 b-2], released
cache_dir = File.join Gem.spec_cache_dir, "gems.example.com%80"
assert File.exist?(cache_dir), "#{cache_dir} does not exist"
cache_file = File.join cache_dir, "specs.#{Gem.marshal_version}"
assert File.exist?(cache_file)
end
def test_load_specs_cached
latest_specs = @source.load_specs :latest
# Make sure the cached version is actually different:
latest_specs << Gem::NameTuple.new("cached", Gem::Version.new("1.0.0"), "ruby")
@fetcher.data["#{@gem_repo}latest_specs.#{Gem.marshal_version}.gz"] = nil
@fetcher.data["#{@gem_repo}latest_specs.#{Gem.marshal_version}"] =
" " * Marshal.dump(latest_specs).length
cache_dir = File.join Gem.spec_cache_dir, "gems.example.com%80"
FileUtils.mkdir_p cache_dir
cache_file = File.join cache_dir, "latest_specs.#{Gem.marshal_version}"
File.open cache_file, "wb" do |io|
Marshal.dump latest_specs, io
end
cached_specs = @source.load_specs :latest
assert_equal latest_specs, cached_specs
end
def test_load_specs_cached_empty
latest_specs = @source.load_specs :latest
# Make sure the cached version is actually different:
latest_specs << Gem::NameTuple.new("fixed", Gem::Version.new("1.0.0"), "ruby")
# Setup valid data on the 'remote'
@fetcher.data["#{@gem_repo}latest_specs.#{Gem.marshal_version}.gz"] =
util_gzip(Marshal.dump(latest_specs))
cache_dir = File.join Gem.spec_cache_dir, "gems.example.com%80"
FileUtils.mkdir_p cache_dir
cache_file = File.join cache_dir, "latest_specs.#{Gem.marshal_version}"
File.open cache_file, "wb" do |io|
# Setup invalid data in the cache:
io.write Marshal.dump(latest_specs)[0, 10]
end
fixed_specs = @source.load_specs :latest
assert_equal latest_specs, fixed_specs
end
def test_load_specs_from_unavailable_uri
src = Gem::Source.new("http://not-there.nothing")
assert_raise Gem::RemoteFetcher::FetchError do
src.load_specs :latest
end
end
def test_spaceship
remote = @source
specific = Gem::Source::SpecificFile.new @specs["a-1"].cache_file
installed = Gem::Source::Installed.new
local = Gem::Source::Local.new
assert_equal(0, remote.<=>(remote), "remote <=> remote") # rubocop:disable Lint/BinaryOperatorWithIdenticalOperands
assert_equal(-1, remote.<=>(specific), "remote <=> specific")
assert_equal(1, specific.<=>(remote), "specific <=> remote")
assert_equal(-1, remote.<=>(local), "remote <=> local")
assert_equal(1, local.<=>(remote), "local <=> remote")
assert_equal(-1, remote.<=>(installed), "remote <=> installed")
assert_equal(1, installed.<=>(remote), "installed <=> remote")
no_uri = @source.dup
no_uri.instance_variable_set :@uri, nil
assert_equal(-1, remote.<=>(no_uri), "remote <=> no_uri")
end
def test_spaceship_order_is_preserved_when_uri_differs
source_a = Gem::Source.new "http://example.com/a"
source_b = Gem::Source.new "http://example.com/b"
assert_equal(0, source_a.<=>(source_a), "source_a <=> source_a") # rubocop:disable Lint/BinaryOperatorWithIdenticalOperands
assert_equal(1, source_a.<=>(source_b), "source_a <=> source_b")
assert_equal(1, source_b.<=>(source_a), "source_b <=> source_a")
end
def test_update_cache_eh
assert @source.update_cache?
end
def test_update_cache_eh_home_nonexistent
FileUtils.rmdir Gem.user_home
refute @source.update_cache?
end
def test_typo_squatting
rubygems_source = Gem::Source.new("https://rubgems.org")
assert rubygems_source.typo_squatting?("rubygems.org")
assert rubygems_source.typo_squatting?("rubyagems.org")
assert rubygems_source.typo_squatting?("rubyasgems.org")
refute rubygems_source.typo_squatting?("rubysertgems.org")
end
def test_typo_squatting_false_positive
rubygems_source = Gem::Source.new("https://rubygems.org")
refute rubygems_source.typo_squatting?("rubygems.org")
end
def test_typo_squatting_custom_distance_threshold
rubygems_source = Gem::Source.new("https://rubgems.org")
distance_threshold = 5
assert rubygems_source.typo_squatting?("rubysertgems.org", distance_threshold)
end
end