ruby/lib/irb/cmd/edit.rb
Stan Lo 2f0f95235a [ruby/irb] Fix SourceFinder's constant evaluation issue
(https://github.com/ruby/irb/pull/869)

Currently, if the signature's constant part is not defined, a NameError
would be raised.

```
irb(main):001> show_source Foo
(eval):1:in `<top (required)>': uninitialized constant Foo (NameError)

Foo
^^^
        from (irb):1:in `<main>'
```

This commit fixes the issue and simplifies the `edit` command's implementation.

8c16e029d1
2024-02-13 13:36:32 +00:00

54 lines
1.3 KiB
Ruby

require 'shellwords'
require_relative "nop"
require_relative "../source_finder"
module IRB
# :stopdoc:
module ExtendCommand
class Edit < Nop
category "Misc"
description 'Open a file with the editor command defined with `ENV["VISUAL"]` or `ENV["EDITOR"]`.'
class << self
def transform_args(args)
# Return a string literal as is for backward compatibility
if args.nil? || args.empty? || string_literal?(args)
args
else # Otherwise, consider the input as a String for convenience
args.strip.dump
end
end
end
def execute(*args)
path = args.first
if path.nil?
path = @irb_context.irb_path
elsif !File.exist?(path)
source = SourceFinder.new(@irb_context).find_source(path)
if source&.file_exist? && !source.binary_file?
path = source.file
end
end
unless File.exist?(path)
puts "Can not find file: #{path}"
return
end
if editor = (ENV['VISUAL'] || ENV['EDITOR'])
puts "command: '#{editor}'"
puts " path: #{path}"
system(*Shellwords.split(editor), path)
else
puts "Can not find editor setting: ENV['VISUAL'] or ENV['EDITOR']"
end
end
end
end
# :startdoc:
end