mirror of
https://github.com/ruby/ruby.git
synced 2025-08-25 14:05:02 +02:00

Currently, the --no-install option to `bundle package` is totally
ignored for git sources. This can have very strange effects if you have:
- a git-sourced gem,
- with native extensions,
- whose extconf.rb script depends on another gem,
- which is installed from Rubygems in the gemfile.
In that circumstance, `bundle package --no-install --all` will download
the Rubygems dependencies to `vendor/cache` but NOT install them. It
will also check out the git gems to `vendor/cache` (good), and attempt
to build their native extensions (bad!).
The native extension build will fail because the extconf.rb script crashes,
since the dependency it needs is missing.
I implemented a fix for this in `source/git.rb`, since this is analogous
to what's happening in `source/rubygems.rb`. I do admit though the whole
thing is a little strange though - an "install" method that.... proceeds
to look at a global flag to not install anything.
Add test to confirm cache respects the --no-install flag
5a77d1c397
Co-authored-by: KJ Tsanaktsidis <kj@kjtsanaktsidis.id.au>
276 lines
8.7 KiB
Ruby
276 lines
8.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "git base name" do
|
|
it "base_name should strip private repo uris" do
|
|
source = Bundler::Source::Git.new("uri" => "git@github.com:bundler.git")
|
|
expect(source.send(:base_name)).to eq("bundler")
|
|
end
|
|
|
|
it "base_name should strip network share paths" do
|
|
source = Bundler::Source::Git.new("uri" => "//MachineName/ShareFolder")
|
|
expect(source.send(:base_name)).to eq("ShareFolder")
|
|
end
|
|
end
|
|
|
|
RSpec.describe "bundle cache with git" do
|
|
it "copies repository to vendor cache and uses it" do
|
|
git = build_git "foo"
|
|
ref = git.ref_for("main", 11)
|
|
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "foo", :git => '#{lib_path("foo-1.0")}'
|
|
G
|
|
|
|
bundle "config set cache_all true"
|
|
bundle :cache
|
|
expect(bundled_app("vendor/cache/foo-1.0-#{ref}")).to exist
|
|
expect(bundled_app("vendor/cache/foo-1.0-#{ref}/.git")).not_to exist
|
|
expect(bundled_app("vendor/cache/foo-1.0-#{ref}/.bundlecache")).to be_file
|
|
|
|
FileUtils.rm_rf lib_path("foo-1.0")
|
|
expect(the_bundle).to include_gems "foo 1.0"
|
|
end
|
|
|
|
it "copies repository to vendor cache and uses it even when configured with `path`" do
|
|
git = build_git "foo"
|
|
ref = git.ref_for("main", 11)
|
|
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "foo", :git => '#{lib_path("foo-1.0")}'
|
|
G
|
|
|
|
bundle "config set --local path vendor/bundle"
|
|
bundle "install"
|
|
bundle "config set cache_all true"
|
|
bundle :cache
|
|
|
|
expect(bundled_app("vendor/cache/foo-1.0-#{ref}")).to exist
|
|
expect(bundled_app("vendor/cache/foo-1.0-#{ref}/.git")).not_to exist
|
|
|
|
FileUtils.rm_rf lib_path("foo-1.0")
|
|
expect(the_bundle).to include_gems "foo 1.0"
|
|
end
|
|
|
|
it "runs twice without exploding" do
|
|
build_git "foo"
|
|
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "foo", :git => '#{lib_path("foo-1.0")}'
|
|
G
|
|
|
|
bundle "config set cache_all true"
|
|
bundle :cache
|
|
bundle :cache
|
|
|
|
expect(out).to include "Updating files in vendor/cache"
|
|
FileUtils.rm_rf lib_path("foo-1.0")
|
|
expect(the_bundle).to include_gems "foo 1.0"
|
|
end
|
|
|
|
it "tracks updates" do
|
|
git = build_git "foo"
|
|
old_ref = git.ref_for("main", 11)
|
|
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "foo", :git => '#{lib_path("foo-1.0")}'
|
|
G
|
|
|
|
bundle "config set cache_all true"
|
|
bundle :cache
|
|
|
|
update_git "foo" do |s|
|
|
s.write "lib/foo.rb", "puts :CACHE"
|
|
end
|
|
|
|
ref = git.ref_for("main", 11)
|
|
expect(ref).not_to eq(old_ref)
|
|
|
|
bundle "update", :all => true
|
|
bundle :cache
|
|
|
|
expect(bundled_app("vendor/cache/foo-1.0-#{ref}")).to exist
|
|
expect(bundled_app("vendor/cache/foo-1.0-#{old_ref}")).not_to exist
|
|
|
|
FileUtils.rm_rf lib_path("foo-1.0")
|
|
run "require 'foo'"
|
|
expect(out).to eq("CACHE")
|
|
end
|
|
|
|
it "tracks updates when specifying the gem" do
|
|
git = build_git "foo"
|
|
old_ref = git.ref_for("main", 11)
|
|
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "foo", :git => '#{lib_path("foo-1.0")}'
|
|
G
|
|
|
|
bundle "config set cache_all true"
|
|
bundle :cache
|
|
|
|
update_git "foo" do |s|
|
|
s.write "lib/foo.rb", "puts :CACHE"
|
|
end
|
|
|
|
ref = git.ref_for("main", 11)
|
|
expect(ref).not_to eq(old_ref)
|
|
|
|
bundle "update foo"
|
|
|
|
expect(bundled_app("vendor/cache/foo-1.0-#{ref}")).to exist
|
|
expect(bundled_app("vendor/cache/foo-1.0-#{old_ref}")).not_to exist
|
|
|
|
FileUtils.rm_rf lib_path("foo-1.0")
|
|
run "require 'foo'"
|
|
expect(out).to eq("CACHE")
|
|
end
|
|
|
|
it "uses the local repository to generate the cache" do
|
|
git = build_git "foo"
|
|
ref = git.ref_for("main", 11)
|
|
|
|
gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "foo", :git => '#{lib_path("foo-invalid")}', :branch => :main
|
|
G
|
|
|
|
bundle %(config set local.foo #{lib_path("foo-1.0")})
|
|
bundle "install"
|
|
bundle "config set cache_all true"
|
|
bundle :cache
|
|
|
|
expect(bundled_app("vendor/cache/foo-invalid-#{ref}")).to exist
|
|
|
|
# Updating the local still uses the local.
|
|
update_git "foo" do |s|
|
|
s.write "lib/foo.rb", "puts :LOCAL"
|
|
end
|
|
|
|
run "require 'foo'"
|
|
expect(out).to eq("LOCAL")
|
|
end
|
|
|
|
it "copies repository to vendor cache, including submodules" do
|
|
# CVE-2022-39253: https://lore.kernel.org/lkml/xmqq4jw1uku5.fsf@gitster.g/
|
|
system(*%W[git config --global protocol.file.allow always])
|
|
|
|
build_git "submodule", "1.0"
|
|
|
|
git = build_git "has_submodule", "1.0" do |s|
|
|
s.add_dependency "submodule"
|
|
end
|
|
|
|
sys_exec "git submodule add #{lib_path("submodule-1.0")} submodule-1.0", :dir => lib_path("has_submodule-1.0")
|
|
sys_exec "git commit -m \"submodulator\"", :dir => lib_path("has_submodule-1.0")
|
|
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
git "#{lib_path("has_submodule-1.0")}", :submodules => true do
|
|
gem "has_submodule"
|
|
end
|
|
G
|
|
|
|
ref = git.ref_for("main", 11)
|
|
bundle "config set cache_all true"
|
|
bundle :cache
|
|
|
|
expect(bundled_app("vendor/cache/has_submodule-1.0-#{ref}")).to exist
|
|
expect(bundled_app("vendor/cache/has_submodule-1.0-#{ref}/submodule-1.0")).to exist
|
|
expect(the_bundle).to include_gems "has_submodule 1.0"
|
|
end
|
|
|
|
it "caches pre-evaluated gemspecs" do
|
|
git = build_git "foo"
|
|
|
|
# Insert a gemspec method that shells out
|
|
spec_lines = lib_path("foo-1.0/foo.gemspec").read.split("\n")
|
|
spec_lines.insert(-2, "s.description = `echo bob`")
|
|
update_git("foo") {|s| s.write "foo.gemspec", spec_lines.join("\n") }
|
|
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "foo", :git => '#{lib_path("foo-1.0")}'
|
|
G
|
|
bundle "config set cache_all true"
|
|
bundle :cache
|
|
|
|
ref = git.ref_for("main", 11)
|
|
gemspec = bundled_app("vendor/cache/foo-1.0-#{ref}/foo.gemspec").read
|
|
expect(gemspec).to_not match("`echo bob`")
|
|
end
|
|
|
|
it "can install after bundle cache with git not installed" do
|
|
build_git "foo"
|
|
|
|
gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "foo", :git => '#{lib_path("foo-1.0")}'
|
|
G
|
|
bundle "config set cache_all true"
|
|
bundle :cache, "all-platforms" => true, :install => false
|
|
|
|
simulate_new_machine
|
|
with_path_as "" do
|
|
bundle "config set deployment true"
|
|
bundle :install, :local => true
|
|
expect(the_bundle).to include_gem "foo 1.0"
|
|
end
|
|
end
|
|
|
|
it "respects the --no-install flag" do
|
|
git = build_git "foo", &:add_c_extension
|
|
ref = git.ref_for("main", 11)
|
|
|
|
gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "foo", :git => '#{lib_path("foo-1.0")}'
|
|
G
|
|
bundle "config set cache_all true"
|
|
|
|
# The algorithm for the cache location for a git checkout is
|
|
# in Bundle::Source::Git#cache_path
|
|
cache_path_name = "foo-1.0-#{Digest(:SHA1).hexdigest(lib_path("foo-1.0").to_s)}"
|
|
|
|
# Run this test twice. This is because materially different codepaths
|
|
# will get hit the second time around.
|
|
# The first time, Bundler::Sources::Git#install_path is set to the system
|
|
# wide cache directory bundler/gems; the second time, it's set to the
|
|
# vendor/cache directory. We don't want the native extension to appear in
|
|
# either of these places, so run the `bundle cache` command twice.
|
|
2.times do
|
|
bundle :cache, "all-platforms" => true, :install => false
|
|
|
|
# it did _NOT_ actually install the gem - neither in $GEM_HOME (bundler 2 mode),
|
|
# nor in .bundle (bundler 3 mode)
|
|
expect(Pathname.new(File.join(default_bundle_path, "gems/foo-1.0-#{ref}"))).to_not exist
|
|
# it _did_ cache the gem in vendor/
|
|
expect(bundled_app("vendor/cache/foo-1.0-#{ref}")).to exist
|
|
# it did _NOT_ build the gems extensions in the vendor/ dir
|
|
expect(Dir[bundled_app("vendor/cache/foo-1.0-#{ref}/lib/foo_c*")]).to be_empty
|
|
# it _did_ cache the git checkout
|
|
expect(default_cache_path("git", cache_path_name)).to exist
|
|
# And the checkout is a bare checkout
|
|
expect(default_cache_path("git", cache_path_name, "HEAD")).to exist
|
|
end
|
|
|
|
# Subsequently installing the gem should compile it.
|
|
# _currently_, the gem gets compiled in vendor/cache, and vendor/cache is added
|
|
# to the $LOAD_PATH for git extensions, so it all kind of "works". However, in the
|
|
# future we would like to stop adding vendor/cache to the $LOAD_PATH for git extensions
|
|
# and instead treat them identically to normal gems (where the gem install location,
|
|
# not the cache location, is added to $LOAD_PATH).
|
|
# Verify that the compilation worked and the result is in $LOAD_PATH by simply attempting
|
|
# to require it; that should make sure this spec does not break if the load path behaviour
|
|
# is changed.
|
|
bundle :install, :local => true
|
|
ruby <<~R, :raise_on_error => false
|
|
require 'bundler/setup'
|
|
require 'foo_c'
|
|
R
|
|
expect(last_command).to_not be_failure
|
|
end
|
|
end
|