mirror of
https://github.com/ruby/ruby.git
synced 2025-08-23 21:14:23 +02:00
3d5febf65b
I previously left a comment stating I didn't know why a certain method existed. In investigating the code in `CaptureCodeContext#capture_before_after_kws` I found that it was added as to give a slightly less noisy output.
The docs for AroundBlockScan#capture_neighbor_context only describe keywords as being a primary concern. I modified that code to only include lines that are keywords or ends. This reduces the output noise even more.
This allows me to remove that `start_at_next_line` method.
One weird side effect of the prior logic is it would cause this code to produce this output:
```
class OH
def hello
def hai
end
end
```
```
1 class OH
> 2 def hello
4 def hai
5 end
6 end
```
But this code to produce this output:
```
class OH
def hello
def hai
end
end
```
```
1 class OH
> 2 def hello
4 end
5 end
```
Note the missing `def hai`. The only difference between them is that space.
With this change, they're now both consistent.
|
||
|---|---|---|
| .. | ||
| api_spec.rb | ||
| around_block_scan_spec.rb | ||
| block_expand_spec.rb | ||
| capture_code_context_spec.rb | ||
| clean_document_spec.rb | ||
| cli_spec.rb | ||
| code_block_spec.rb | ||
| code_frontier_spec.rb | ||
| code_line_spec.rb | ||
| code_search_spec.rb | ||
| core_ext_spec.rb | ||
| display_invalid_blocks_spec.rb | ||
| explain_syntax_spec.rb | ||
| lex_all_spec.rb | ||
| pathname_from_message_spec.rb | ||
| priority_queue_spec.rb | ||