mirror of
https://github.com/ruby/ruby.git
synced 2025-08-25 05:55:46 +02:00
c77354157f
Resolver had internal logic to prioritize locked versions when sorting
versions, however part of it was not being actually hit because of how
unlocking worked in the resolver: a package was allow to be unlocked
when that was explicit requested or when the list of unlocks was empty.
That did not make a lot of sense and other cases were working because
the explicit list of unlocks was getting "artificially filled".
Now we consider a package unlocked when explicitly requested (`bundle
update <package>`), or when everything is being unlocked (`bundle
install` with no lockfile or `bundle update`).
This makes things simpler and gets the edge case added as a test case
working as expected.
b8e55087f0
94 lines
2.3 KiB
Ruby
94 lines
2.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module Bundler
|
|
class Resolver
|
|
#
|
|
# Represents a gem being resolved, in a format PubGrub likes.
|
|
#
|
|
# The class holds the following information:
|
|
#
|
|
# * Platforms this gem will be resolved on.
|
|
# * The locked version of this gem resolution should favor (if any).
|
|
# * Whether the gem should be unlocked to its latest version.
|
|
# * The dependency explicit set in the Gemfile for this gem (if any).
|
|
#
|
|
class Package
|
|
attr_reader :name, :platforms, :dependency, :locked_version
|
|
|
|
def initialize(name, platforms, locked_specs:, unlock:, prerelease: false, prefer_local: false, dependency: nil, new_platforms: [])
|
|
@name = name
|
|
@platforms = platforms
|
|
@locked_version = locked_specs.version_for(name)
|
|
@unlock = unlock
|
|
@dependency = dependency || Dependency.new(name, @locked_version)
|
|
@top_level = !dependency.nil?
|
|
@prerelease = @dependency.prerelease? || @locked_version&.prerelease? || prerelease ? :consider_first : :ignore
|
|
@prefer_local = prefer_local
|
|
@new_platforms = new_platforms
|
|
end
|
|
|
|
def platform_specs(specs)
|
|
platforms.map do |platform|
|
|
prefer_locked = @new_platforms.include?(platform) ? false : !unlock?
|
|
GemHelpers.select_best_platform_match(specs, platform, prefer_locked: prefer_locked)
|
|
end
|
|
end
|
|
|
|
def to_s
|
|
@name.delete("\0")
|
|
end
|
|
|
|
def root?
|
|
false
|
|
end
|
|
|
|
def top_level?
|
|
@top_level
|
|
end
|
|
|
|
def meta?
|
|
@name.end_with?("\0")
|
|
end
|
|
|
|
def ==(other)
|
|
self.class == other.class && @name == other.name
|
|
end
|
|
|
|
def hash
|
|
@name.hash
|
|
end
|
|
|
|
def unlock?
|
|
@unlock == true || @unlock.include?(name)
|
|
end
|
|
|
|
def ignores_prereleases?
|
|
@prerelease == :ignore
|
|
end
|
|
|
|
def prerelease_specified?
|
|
@prerelease == :consider_first
|
|
end
|
|
|
|
def consider_prereleases!
|
|
@prerelease = :consider_last
|
|
end
|
|
|
|
def prefer_local?
|
|
@prefer_local
|
|
end
|
|
|
|
def consider_remote_versions!
|
|
@prefer_local = false
|
|
end
|
|
|
|
def force_ruby_platform?
|
|
@dependency.force_ruby_platform
|
|
end
|
|
|
|
def current_platform?
|
|
@dependency.current_platform?
|
|
end
|
|
end
|
|
end
|
|
end
|