mirror of
https://github.com/ruby/ruby.git
synced 2025-08-23 21:14:23 +02:00
57459b83a9
This commit is to add an extra option to enable verbose mode (V=1) in the generated `Makefile` at runtime of the Ruby to print compiler command lines by the commands below when building native extensions. It's possible to enable the verbose mode by setting the environment variable `MAKEFLAGS="V=1"`[1] implemented in GNU make. However, I wanted to make a consistent user-interface not depending on the specific make's implementation. ``` $ ruby /path/to/extconf.rb -- --with-verbose ``` You can also add the extra option via rake-compiler gem. ``` $ rake compiler -- --with-verbose ``` If the extra option is not given, the value of the `RbConfig::CONFIG["MKMF_VERBOSE"]` enabled by the configure option below is used. ``` $ ./configure --enable-mkmf-verbose ``` For the unit tests, updated the following files. * The `test/mkmf/test_configuration.rb` was created to test the cases with the `configuration` method and this implementation. * Updated the `TestMkmf#assert_separately` to set the extra arguments in `test/mkmf/base.rb`. Updated tests using the `assert_separately`. * Added tests for `MakeMakefile#with_config` in the `test/mkmf/test_config.rb`. [1] https://www.gnu.org/software/make/manual/html_node/Variables_002fRecursion.html Fixes [Bug #19695] Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
39 lines
1,007 B
Ruby
39 lines
1,007 B
Ruby
# frozen_string_literal: false
|
|
require_relative 'base'
|
|
|
|
class TestMkmfConfiguration < TestMkmf
|
|
def test_verbose_with_rbconfig_verbose_disabled
|
|
makefile = mkmf do
|
|
self.class::CONFIG['MKMF_VERBOSE'] = "0"
|
|
init_mkmf(self.class::CONFIG)
|
|
configuration '.'
|
|
end
|
|
verbose = makefile.grep(/^V =/).first[/^V = (.)$/, 1]
|
|
|
|
assert_equal "0", verbose
|
|
end
|
|
|
|
def test_verbose_with_rbconfig_verbose_enabled
|
|
makefile = mkmf do
|
|
self.class::CONFIG['MKMF_VERBOSE'] = "1"
|
|
init_mkmf(self.class::CONFIG)
|
|
configuration '.'
|
|
end
|
|
verbose = makefile.grep(/^V =/).first[/^V = (.)$/, 1]
|
|
|
|
assert_equal "1", verbose
|
|
end
|
|
|
|
def test_verbose_with_arg
|
|
assert_separately([], %w[--with-verbose], <<-'end;')
|
|
makefile = mkmf do
|
|
self.class::CONFIG['MKMF_VERBOSE'] = "0"
|
|
init_mkmf(self.class::CONFIG)
|
|
configuration '.'
|
|
end
|
|
verbose = makefile.grep(/^V =/).first[/^V = (.)$/, 1]
|
|
|
|
assert_equal "1", verbose
|
|
end;
|
|
end
|
|
end
|